adfisch
Forum Replies Created
-
Hi Luis,
thank your for your fast reply and forwarding the idea. In the meantime, is there a way to programatically disable the SmartCrawl box for certain post types? I just realized I only have the code snippet to disable it for certain taxonomies (https://wordpress.org/support/topic/disable-smartcrawl-for-certain-taxonomies/).
Thank you so much in advance.
Forum: Plugins
In reply to: [W3 Total Cache] Feature request: Recognize JS ES6 modulesHi @vmarko,
since you haven’t replied, yet, I thought the solution cannot be as easy as I anticipated. Thus, I had a further look into this and wanted to contribute what I found out.
In order for W3TC to work with ES6 modules, it would need the following updates:
A) Modules will likely not work with all JS minifiers/compressors. I found that Terser works perfectly when using the setting module: true. So either Terser needs to be added to the compressor list or the other compressors need to be examined for their ES6 module support.
B) Modules (by their nature) cannot be combined, so they must be excluded from combine automatically.
C) For modules to be recognized as such by the browser, the script attribute “type” must be preserved when inserting the minified script:
<script type="module" src="path/to/minified/file.js">.I hope this idea finds its way to the developers since this would greatly enhance W3TC. I would appreciate an answer if this feature will ever be introduced and – if yes – what the estimated timeline is. If you need any assistance, I would love to help.
Thanks for your reply!
Hi @shanedelierrr,
thank you for your fast and competent feedback.
Concerning the deprecated messages: I have done some more research on these messages after realizing some of them will even be displayed when using PHP 7.4. Deprecated messages mean that your codes uses a functionality that will be removed in the future, however, is not considered an error with the current PHP version. With this background information I expected your developers might not fix the messages in the near future (which is understandable). Thus, we had some intense discussion with the hosting company and they finally managed to hide deprecated errors.
In sum, the problem seems to be solved on our side. However, the information might still be helpful for your developers in the long run.
Creating users with weak passwords: I used the admin interface for managing users and ticked the “Confirm use of weak password” box. I was expecting this function not to work anymore.
Replication of error messages: The deprecated warnings occured since she set up the email 2FA (unfortunately, she cannot remember the exact stage). After that, the warnings will appear when she accesses the login page event before attempting to login. I could not replicate the warning myself but have copied them off screenshots, so they actually appeared.
Again, thank you for your great help. I will mark this thread as closed since the problem is solved on our side. I hope, the discussion was still helpful to you. 🙂
Thanks for your fast reply. As requested:
- PHP-Version: The warnings occur for 8.0, 8.1 and 8.2 (we tested all), it seems to work with PHP 7.4
- WordPress-Version: 6.1.1
- Plugin-Version: 8.1.4
We are looking forward to your reply!
Short update: So the (stupid) hosting company my customer is with allows only directory-based changes to the PHP settings making it impossible to hide error messages.
I would really appreciate if one of the developers could look into this as the errors definitely occur as of PHP 8.0 and PHP 7.4 has already reached end of life. So PHP 8.0 compatibility should be a must-have, right? 🙂
Thank you very much in advance.
Hi @nlpro,
thank you for your reply.
I already rolled back to PHP 8.0 but the notices still appear. So I guess there’s still some work to be done in order to be fully PHP8-ready.
You’re right, the fact that the messages appear got me a little bit confused since I have WP_DEBUG set to false and error_reporting(0);. Seems the server must overwrite the settings somehow. I will check.
Thanks.
Hi @ironikus,
thank you very much for your fast reply. Just out of curiosity (I understand you develop this plugin in your free time – so no hustle): Is there a timeline for the next release? Thanks for your answer! 🙂
Forum: Plugins
In reply to: [W3 Total Cache] Feature request: Recognize JS ES6 modulesForum: Plugins
In reply to: [W3 Total Cache] Feature request: Recognize JS ES6 modulesHello @vmarko,
thanks for your fast reply. I am using JSMin on disk. However, I think it does not matter which minification method is used. The problem is rather how the minified script is embedded. For example, I use custom code to be able to insert JS modules:
<script type=”module” src=”PATH-TO-JS-MODULE.JS”></script>
However, after minification the type=”module” attribute will get lost:
<script src=”PATH-TO-MINIFIED-FILE.js></script>
It would be awesome if the minification module could recognize the type=”module” attribute and preserve it for minified scripts. I think that’s “all” that needs to be done.
Thank you very much in advance! 🙂
- This reply was modified 3 years, 11 months ago by adfisch.
If that was a long response time, I want to know what your short one is… 😀 Thank you very much, it worked like a charme.
For other readers it might be noteworthy that the above code will disable the SmartCrawl meta box for all taxonomies. If you only wish to disable it for certain taxonomies you can use this code:
... $taxonomy = smartcrawl_get_array_value( $_GET, 'taxonomy' ); $disabled_taxonomies = array( 'taxonomy_slug1', 'taxonomy_slug2' ); if ( ! in_array( $taxonomy, $disabled_taxonomies ) ) { return; } if ( is_admin() && ! empty( $taxonomy ) ) { ...- This reply was modified 5 years, 2 months ago by adfisch.
Yes, exactly. 🙂
Hi Predrag & Patrick,
sorry for my late reply. Your solution works like a charme. 🙂
Best regards from Germany.