sky
Forum Replies Created
-
Forum: Plugins
In reply to: [The Events Calendar] custom css not loadingThere you go.
Thanks again.
Forum: Plugins
In reply to: [The Events Calendar] custom css not loadingOh for frack’s sake.
There was somehow a space at the front of the filename. Everything is working as it should.
Sorry to waste your time.
Thanks for the great plugin!
Forum: Plugins
In reply to: [Authorizer] Only Super Admins Can Add/Change UsersWell, after a lot of digging around, I came up with a solution, which I submitted on GitHub.
For anyone wondering, it is the capability “create_user” that is tied to the “Add New Users” option in Network Settings. For some reason “add_users” is true for site admins whether or not “Add New Users” is checked or not.
The patch I submitted allows site admins to add/edit users in the Authorizer settings, but only if the “Add New Users” is checked in network settings. Otherwise, site admins do not even see the Authorizer settings in the menu.
I took this approach because I was reluctant to change the default user permissions for administrators, in case core or other themes/plugins use them the way they are.
Forum: Plugins
In reply to: [Authorizer] Only Super Admins Can Add/Change UsersIt appears that enabling “Allow site administrators to add new users…” gives the site admin the “add_user” capability, but not “edit_user”, which is what your methods use to check permissions. A quick find and replace of “edit_user” with “add_user”, and I am able to add users as a site admin.
I will do some more testing of this, and submit a patch on Github for your consideration.
Thanks!
Forum: Plugins
In reply to: [Authorizer] Only Super Admins Can Add/Change UsersNow that I’ve had my first cup of coffee, I have something to add.
In the multisite network settings, there is an option for “Allow site administrators to add new users”.
I think that if this is disabled, site admins shouldn’t even see the Authorizer settings in their dashboard. If anything, just a list of approved/blocked users.
If enabled, they should be able to add/edit users via the Authorizer same as the super admin.
Forum: Plugins
In reply to: [Authorizer] Only Super Admins Can Add/Change UsersI could have sworn that I was able to successfully add users in Authorizer as a site admin before. Maybe didn’t test as thoroughly as I thought.
Anyway, it would be great if all I have to do is edit the capabilities to fix it. I’ll look at that today.
Thanks for the great plugin!
Sidebar: I know I’ve interacted with you on another forum in years past. Small world.
Forum: Fixing WordPress
In reply to: Enable "shift-click to edit" on custom widgetsOh for f*ck’s sake.
In my custom widgets, I had omitted adding the ID to ‘before_widget’ markup, as I wasn’t using the IDs for styling. Turns out this is what the Customizer JS is using to target the widgets. (duh)
So, including the proper ID in the widget output makes everything work as it should.
Forum: Fixing WordPress
In reply to: Enable "shift-click to edit" on custom widgetsAn Update:
I just found out that this should be happening by default. So, there must be something when registering a custom widget that by design or as a side affect enables this functionality. I’m not seeing any other type of bug in my widgets, so am perplexed as to what I’m leaving out.
Forum: Fixing WordPress
In reply to: Enable "shift-click to edit" on custom widgetsThanks Clayton,
The bug described in that ticket is independent of what I’m asking, and has been fixed in 4.1.
The default WordPress widgets behave as they are supposed to when shift clicked.
Whatever javascript event that is triggered when shift-clicking a widget in the preview – that connects the widget that you click with the corresponding customizer panel and section, is not being attached to my custom widgets.
There has to be some way to register a custom widget so that instances of the widget would be on the javascript’s ‘radar’ when watching for shift-clicks.
From reading your second link (which I had already been tracking on btw) I can see the possibility of manually expanding the widgets by creating my own onclicks. However, since WordPress is already adding all of the default widgets to the event handler somewhere, it seems like there should be a hook or filter where you could add additional widgets to watch.
This is what I’m trying to figure out.
Anyway, thanks for trying to help. Hopefully, this will be documented soon, as it seems like something that would quickly become a common question from theme and plugin developers who create custom widgets.
Forum: Alpha/Beta/RC
In reply to: 4.1 RC1 – new inline pop-up alignment buttonsThanks for posting this. I’ll be able to use it as a temporary fix until I can figure out how to get the alignment to apply to the image wrapper, and not the image itself. Now to figure out how to disable the image resizing ‘feature’.
Forum: Plugins
In reply to: [Image Widget] Image Widget Doesn't Work In Theme CustomizerI’m working on a similar image widget plugin that was having the exact same issue.
The gist of my issue was that after selecting the image from the image library, the image url was inserted into the field, but the change was not detected, and the ‘widget-updated’ event not fired. I added a line of js that triggers the ‘change’ event on the field, which in turn fires the ‘widget-updated’ event.
$(input).trigger('change');where input is the input id.
Not sure if this has been addressed in the image-widget plugin yet, but if not, they just need to manually trigger the change event in image-widget.js.
Forum: Plugins
In reply to: [Multisite Enhancements] "Active In" – Not Displaying Subdomain'sForgot to add, I’m using version 1.0.5 which claims to have fixed this issue.
Forum: Plugins
In reply to: [Multisite Enhancements] "Active In" – Not Displaying Subdomain'sJust dealt with a major mishap because of this! I inherited a large multisite network, and was trying to remove unused plugins to beef up security. I used the information in the “active in” column to make this decision, which turned out to be a big mistake.
The sites in question are subdomain sites, and the plugins installed in them claim “not active”.
I installed “active plugins on multisite” and it correctly displays the information, while in this plugin, not so much.
I really liked all the functionality that this plugin offers, but can no longer trust the information that it provides. I also noticed that sites are not being listed on the themes page under themes that they are using. So, yeah. People, don’t base any decisions on the information that this plugin displays until it is fixed.
Yes, this IS extremely confusing. I love this plugin, but this really needs fixing.