Yes but no

  • NightL

    (@nightl)


    9 years ago

    I like the idea of this and I believe this plugin would be a benefit for those who wish to place a LOT of large dimension images on their website.

    For my purposes I will remove the plugin and will have to go through code to remove unnecessary and unwanted code.

    When I need it, it will be much easier to manually put the code in and utilise the varying sizes WordPress outputs when uploading images.

    Browser support for the srcset attribute is still limited – initially I thought it still a great idea to benefit those who use browsers that support srcset.

    But

    I regularly place small images/thumbnails that link to lightbox versions. The plugin was placing code onto the 150×150 thumbnails – which is pointless and adds code clutter.

    I deactivated the plugin, deciding only to turn it on for inserting large images. Recently I discovered, on opening up the read more divs on my website that all the images within were now displaying at 100% width. This totally broke the layout of the pages and obviously images of 200px wide now looked horrible when displaying many times bigger than actual resolution. I activated the plugin and the images displayed correctly again – but now I am back with unnecessary code being added to thumbnails. The reason I didn’t notice this earlier was all other images inserted, while plugin was activated, beyond the expanding divs were in max-width containers. I believe a recent WordPress or plugin update created this display issue.

    If there were a check box added within the Add Media section that would allow the code only to be placed when checked would make me be happy to have the plugin installed and activated.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Thread Starter NightL

    (@nightl)

    9 years ago

    OK – Just so I am clear on this, the new version 5.2.0 with “Responsify all post images by adding srcset and sizes through a display filter” means I can get rid of all existing srcset code?

    Does this also mean now, that deactivating the plugin will have no impact on layout for images inserted after 5.2.0? (as mentioned above I can remove existing srcset code?)

    So I now see clean simple insert code on my Text display when editing – no added srcset code – the filter now applies the srcset code. Inspect element/View source will indicate it is there due to the display filter. (?)

    If all the above is true, I am very close to changing/improving my Review and Star rating.

    Just one more issue sorted would make this plugin perfect (for the time).

    I have noted 5.2.0 has not added display filter srcset code to my 150×150 thumbnails (YES!!!) – yet my medium size display of an image at 300px gets the treatment. So I have chosen to display a medium size image – I still see adding in the source, via filter, of srcset code for sizes all above the actual dimensions I chose to have (when selecting Medium at Add Media) – to my mind this is still delivering a lot of completely unnecessary code down to the browser.

    src="http://www.xxxx.com/wp-content/uploads/my-image-300x179.jpg" width="300" height="179" data-sizes="(max-width: 300px) 100vw, 300px" srcset="http://www.xxxx.com/wp-content/uploads/my-image-300x179.jpg 300w, http://www.xxxx.com/wp-content/uploads/my-image-1024x612.jpg 1024w, http://www.xxxx.com/wp-content/uploads/my-image-540x320.jpg 540w, http://www.xxxx.com/wp-content/uploads/my-image-1100x657.jpg 1100w, http://www.xxxx.com/wp-content/uploads/my-image-800x478.jpg 800w, http://www.xxxx.com/wp-content/uploads/my-image.jpg 1200w" sizes="(max-width: 300px) 100vw, 300px"

    _________________
    I have my thumbnails linking to wp-jquery-lightbox – I also note the display filter does not cover the full size images displayed within the wp-jquery-lightbox. I don’t really see this is an issue, though, as I have clearly offered the viewer a choice to see the full size image and not pushed it on them.

    …but I am getting close to changing my review

    Shapeshifter 3

    (@shapeshifter-3)

    9 years ago

    NightL,

    Some updates that might make you feel more comfortable with this plugin:

    1. It has been updated to version 2.5.2 with these changes: https://wordpress.org/plugins/ricg-responsive-images/changelog/.

    2. It is on its way to being merged into WordPress Core:
    https://make.wordpress.org/core/2015/09/30/responsive-images-merge-proposal/

    3. A first pass patch was added to the Core today: https://core.trac.wordpress.org/ticket/33641#comment:9

    4. You can follow its progression on Slack if you have an account: https://wordpress.slack.com/archives/feature-respimg (if not, sign up for one).

    Shapeshifter 3

    (@shapeshifter-3)

    9 years ago

    NightL,

    Here’s the initial merge commit to Core: https://core.trac.wordpress.org/changeset/34855

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Yes but no’ is closed to new replies.