WPO Tips II

  • Resolved Josef Seidl

    (@blogitsolutions)


    11 years, 9 months ago

    Hi Dario,

    thanks for the new update an realizing some optimization stuff. I did a brief check and realized a few things:

    1) Not all pictures are optimized. See https://dl.dropboxusercontent.com/u/40617157/Foren/PictureOptimization.png

    2) In yasr.css you are loading css code in the front-end which is not needed there because there is a lot of “only back-end code” in this file.

    3) In Firebug im receiving the following message: “js/jquery.rateit.min.js?ver=1.0.20 is being assigned a //# sourceMappingURL, but already has one”

    4) At the moment there is the picture /img/delete.gif loaded. Any reason for this? 😉

    I just sent you the updated translation file for German.

    Best,
    Josef

    https://wordpress.org/plugins/yet-another-stars-rating/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Contributor dudo

    (@dudo)

    11 years, 9 months ago

    1) I don’t know Imageoption, but it says that I didn’t optimized that 4 images. But that 4 images are the only ones that I’ve optimized 😀 I’ve used this tools https://tinypng.com/ (it worked great, all that files were about 5KB)

    2) You’re absolutelly right, I will move admin rules in another file that will be called only in admin area

    3) This is pretty strange: I use firebug too but it never showed that error. Where do you get it?

    4) Just like I said in the description, YASR is based on jquery plugin called RateIT http://rateit.codeplex.com/ . Rateit call the delete.gif and than hide that button, if the rule “resetable” is set to “false”.

    Have a nice day!
    Dario

    Thread Starter Josef Seidl

    (@blogitsolutions)

    11 years, 8 months ago

    1) Just sent you the optimized pictures via e-mail. Do not hesitate to use it 🙂

    2) That’s great!

    3) Have a look at the following screenshot: https://dl.dropboxusercontent.com/u/40617157/Foren/Firebug-Warning.png
    Also the inline JS-Code makes some trouble if you load the other JS-Code (e.g. jQuery) at the bottom of the html document.

    4) Any possibility to fix this? E.g. to speak to the developers of RateIT? It’s a much better solution instead of hidding this picture not to load it.

    Have a nice day too,
    Josef

    Plugin Contributor dudo

    (@dudo)

    11 years, 8 months ago

    3) I still cannot reproduce that warning: so I need you to try this 🙂
    open file js/jquery.rateit.min.js and remove this line:

    /*
    //# sourceMappingURL=jquery.rateit.min.js.map
    */

    I don’t think this will work, just a try 🙂

    4) I will do, but for now this is not a priority

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘WPO Tips II’ is closed to new replies.