Version 9.2.0

  • Resolved nexxtpress

    (@nexxtpress)


    1 week ago

    Version 9.2.0 seems to have broken federation on my blog.

    When I search for a link to a previously posted/federated post, i.e. on Mastodon, it returns “No results.” (“Keine Ergebnisse”) Whereas rolling the plugin back to Version 9.1.0 returns the full post again.

    I am not using any other cache plugins than “Redis Object Cache” (Version 2.8.0) and “Surge” (Version 1.2.1).

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Matthias Pfefferle

    (@pfefferle)

    1 week ago

    hey @nexxtpress 👋

    is it only for existing blog posts or also new ones? Can you tell me which blog you have issues with?

    Plugin Author Matthias Pfefferle

    (@pfefferle)

    1 week ago

    If it is about nexxtpress.de, can you tell me what version is currently installed?

    Thread Starter nexxtpress

    (@nexxtpress)

    1 week ago

    Hej @pfefferle, I just turned on Version 9.2.0 again. Try https://nexxtpress.de/mediathekperlen/nicolas-cage-ghost-rider-2007/ (last post in the blog).

    WordPress Version 7.0.2

    • This reply was modified 1 week ago by nexxtpress. Reason: added WordPress Version
    Plugin Author Matthias Pfefferle

    (@pfefferle)

    1 week ago

    I found the issue, and I am really sorry!

    It comes from a change I made to how the plugin decides whether a request is an ActivityPub request or a normal page view. To work better together with a caching layer, I made that check stricter: it now only treats a request as ActivityPub when the Accept header asks for JSON and nothing else.

    The problem is that Mastodon also lists text/html in its Accept header, just with a very low priority. My stricter check saw that text/html and stopped recognizing the request as ActivityPub, so the plugin returned the normal HTML page instead of the JSON, and the posts no longer resolved.

    I only tested with a plain application/activity+json header, not with the one Mastodon actually sends, so I missed it. Compatibility in WordPress is hard!

    I will roll the change back so federation works again, and fix the third party caching plugin properly instead. Thanks a lot for the report and for your patience.

    Thread Starter nexxtpress

    (@nexxtpress)

    1 week ago

    Ahh! That’s great, Matthias! Thank you very much (as always!) for the quick turnaround!

    Plugin Author Matthias Pfefferle

    (@pfefferle)

    1 week ago

    It will go live with the next version I planned for Monday: https://github.com/Automattic/wordpress-activitypub/pull/3601

Viewing 6 replies - 1 through 6 (of 6 total)

You must be logged in to reply to this topic.