Update ID generation

Resolved wirlen
(@wirlen)

4 months, 2 weeks ago

I could not see an option to contribute to this project so I will send this as a support request and you can do what you like with it.

But we run into a problem when we bulk import products. Tje code uses addition (timestamp + product_id) to generate UUIDs. This causes different products to get the same UUID during bulk imports:

Product A: timestamp 1700000000 + ID 100 = 1700000100
Product B: timestamp 1700000050 + ID 50 = 1700000100

So for us this creates issues since we import lots of products, and I think the plugin would benifit from a hash function instead of addition to guarantee unique UUIDs while keeping them deterministic. I would gladly provide a PR for this.

Best and thanks for doing the hard work 🙂

The page I need help with: [log in to see the link]

Viewing 7 replies - 1 through 7 (of 7 total)

Plugin Support Krystian Syde
(@inpsydekrystian)

4 months, 2 weeks ago

Hello @wirlen

Nice timing, because we have only recently opened the repository for that project. You can find it here:
https://github.com/inpsyde/paypal-point-of-sale

Our developers confirmed that contributions are welcome, so you are absolutely free to submit a PR for this. One thing to keep in mind is that the UUID generation in this project is meant to follow specific requirements and a version 1 style format. You can see the current implementation and constraints here:
https://github.com/inpsyde/paypal-point-of-sale/blob/9b60cf757f4145a5f4396b9b1f765a7129f89092/modules.local/paypal-pos-php-sdk/src/Uuid/Uuid.php#L16-L32

Because of that, the solution probably needs to keep the same basic structure while improving the uniqueness for bulk imports. Thank you again for taking the time to analyse this and for offering to contribute, it is really appreciated.

Kind Regards,
Krystian

Thread Starter wirlen
(@wirlen)

4 months, 2 weeks ago

Aah great! however I get a 404 could it be that its not public?

I will also look trough the contraints before I submit any PR .

Best regards
Johan

Plugin Support Krystian Syde
(@inpsydekrystian)

4 months, 2 weeks ago

Hello @wirlen

Sorry, I updated the link, but it looks like I wasn’t fast enough: https://github.com/inpsyde/paypal-point-of-sale

Kind regards,
Krystian

Thread Starter wirlen
(@wirlen)

4 months, 2 weeks ago

Hello Krystian,

Thanks for that. I have made my changes locally but seem unable to push the branch could you please look over the access so I can make the PR proper 🙂

Thanks.
Thread Starter wirlen
(@wirlen)

4 months, 2 weeks ago
Sorry forgot the error message: “git push origin improvement/UUIDGeneration
ERROR: Permission to inpsyde/paypal-point-of-sale.git denied to …”
- This reply was modified 4 months, 2 weeks ago by wirlen.
Plugin Support Krystian Syde
(@inpsydekrystian)

4 months, 2 weeks ago
Hello @wirlen ,

The error you see is expected. The repository has branch protection rules and we do not grant direct push access to external contributors. The recommended workflow is to fork the repository and open a pull request from your fork. GitHub describes this process here:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

In short:
1. Fork inpsyde/paypal-point-of-sale to your own GitHub account.
2. Push your improvement/UUIDGeneration branch to your fork (you will have permission there).
3. Create a pull request from your fork’s branch to our repository’s main branch.
Once the PR is open, we will review it and follow up with any feedback.

Kind Regards,
Krystian
Thread Starter wirlen
(@wirlen)

4 months, 1 week ago

Aah sorry I just been lazy, become so common to just be able to push it. Sorry bout that.

Viewing 7 replies - 1 through 7 (of 7 total)

You must be logged in to reply to this topic.

Tags