title="" have some problems

  • Resolved Nikoya

    (@nicolas-andre)


    12 years, 7 months ago

    Hello,

    First thing : you make a great jobs. thanks.

    I’ve found different problem with the version 1.1 of this plugin.

    1, adding ‘ in the title break javascript.
    In french ‘ is often used like “plus d’informations” for exemple
    The string need to be sanitized.

    2, if using this plugin more than 1 time in the same page/post, only the first title=”” is used everywhere.
    All other title are ignored.

    Thank you again for your great job.

    http://wordpress.org/plugins/easy-responsive-tabs/

Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author osCitas Themes

    (@oscitas)

    12 years, 7 months ago

    Hi,

    Thanks you using our plugin, and I will check the issue #1.

    Regarding #2, you are trying to use nested tabs or two different tabs on same page?

    Thanks

    Thread Starter Nikoya

    (@nicolas-andre)

    12 years, 7 months ago

    #2 4 different tabs in column from your other plugin “easy bootstrap shortcode”

    Plugin Author osCitas Themes

    (@oscitas)

    12 years, 7 months ago

    Can you paste the generated shortcode here?

    Thread Starter Nikoya

    (@nicolas-andre)

    12 years, 7 months ago

    Hello

    This is my page :

    First test is More1, then second text is More2

    [restabs text="More1"]
[restab title="Tab number 1 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N" active="active"]Tab 1 content goes here.[/restab]
[restab title="Tab number 2 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N"]Tab 2 content goes here.[/restab]
[restab title="Tab number 3 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N"]Tab 3 content goes here.[/restab]
[restab title="Tab number 4 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N"]Tab 4 content goes here.[/restab][/restabs]

[restabs text="More2"]
[restab title="Tab number 1 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N" active="active"]Tab 1 content goes here.[/restab]
[restab title="Tab number 2 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N"]Tab 2 content goes here.[/restab]
[restab title="Tab number 3 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N"]Tab 3 content goes here.[/restab]
[restab title="Tab number 4 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N"]Tab 4 content goes here.[/restab][/restabs]

    This the the generated Html / JS code :

    <article class="content content-main">
      <div class="tabbable  ">
            <ul class="nav osc-res-nav nav-tabs" id="oscitas-restabs-0">
                  <li class="dropdown pull-right tabdrop">
                        <a class="dropdown-toggle" data-toggle="dropdown" href="#">More1 <b class="caret"></b></a>
                        <ul class="dropdown-menu">
                              <li class="">
                                    <a href="#ert-pane-0-2" data-toggle="tab">Tab number 3 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N</a>
                              </li>
                              <li class="">
                                    <a href="#ert-pane-0-3" data-toggle="tab">Tab number 4 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N</a>
                              </li>
                        </ul>
                  </li>
                  <li class="active">
                        <a href="#ert-pane-0-0" data-toggle="tab">Tab number 1 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N</a>
                  </li>
                  <li class="">
                        <a href="#ert-pane-0-1" data-toggle="tab">Tab number 2 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N</a>
                  </li>
            </ul>
            <div class="tab-content">
                  <div class="tab-pane active" id="ert-pane-0-0">Tab 1 content goes here.</div>
                  <div class="tab-pane " id="ert-pane-0-1">Tab 2 content goes here.</div>
                  <div class="tab-pane " id="ert-pane-0-2">Tab 3 content goes here.</div>
                  <div class="tab-pane " id="ert-pane-0-3">Tab 4 content goes here.</div>
            </div>
      </div>
      <script>
        jQuery(document).ready(function() {
            jQuery('.osc-res-nav').tabdrop({
            'text': 'More1'
            });
        });
    </script>
<p>&nbsp;</p>
      <div class="tabbable  ">
            <ul class="nav osc-res-nav nav-tabs" id="oscitas-restabs-1">
                  <li class="dropdown pull-right tabdrop">
                        <a class="dropdown-toggle" data-toggle="dropdown" href="#">More1 <b class="caret"></b></a>
                        <ul class="dropdown-menu">
                              <li class="">
                                    <a href="#ert-pane-1-2" data-toggle="tab">Tab number 3 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N</a>
                              </li>
                              <li class="">
                                    <a href="#ert-pane-1-3" data-toggle="tab">Tab number 4 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N</a>
                              </li>
                        </ul>
                  </li>
                  <li class="active">
                        <a href="#ert-pane-1-0" data-toggle="tab">Tab number 1 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N</a>
                  </li>
                  <li class="">
                        <a href="#ert-pane-1-1" data-toggle="tab">Tab number 2 Lorem ipsum dolor sit amet, consectetur adipiscing elit. N</a>
                  </li>
            </ul>
            <div class="tab-content">
                  <div class="tab-pane active" id="ert-pane-1-0">Tab 1 content goes here.</div>
                  <div class="tab-pane " id="ert-pane-1-1">Tab 2 content goes here.</div>
                  <div class="tab-pane " id="ert-pane-1-2">Tab 3 content goes here.</div>
                  <div class="tab-pane " id="ert-pane-1-3">Tab 4 content goes here.</div>
            </div>
      </div>

<script>
        jQuery(document).ready(function() {
            jQuery('.osc-res-nav').tabdrop({
            'text': 'More2'
            });
        });
    </script>
    </article>

    As you can see there is only Text1 in html code.

    Thx

    Plugin Author osCitas Themes

    (@oscitas)

    12 years, 7 months ago

    Hi,

    I have fixed the issue, please take update.

    Thanks

    Thread Starter Nikoya

    (@nicolas-andre)

    12 years, 7 months ago

    Hi,

    #2 Seems to be ok.

    Good Job !!!

    Thanks

    Thread Starter Nikoya

    (@nicolas-andre)

    12 years, 6 months ago

    Hello

    The issue #1 is still here.

    Adding this line 110 just before “do_shortcode($content);” seems to correct this issue :

    $text = addslashes($text);

    If it’s correct, maybe you can add this to an update ? please ^^

    Thx

    Plugin Author osCitas Themes

    (@oscitas)

    12 years, 6 months ago

    Hi Nikoya,

    Thanks for the solution, I was busy in some other tasks so have not got chance to look into it. I am pushing your code to plugin.

    Thanks for suppport 🙂

    Thread Starter Nikoya

    (@nicolas-andre)

    12 years, 6 months ago

    Already update ! 🙂

    you are so fast.

    glad to have helped.

Viewing 9 replies - 1 through 9 (of 9 total)

The topic ‘title="" have some problems’ is closed to new replies.