• Resolved Alex Lion (阿力獅)

    (@alexclassroom)


    Hi,

    I fully localize this plugin and it has a text domain issue.

    I modified the following code to correct them.

    drophtml.php, line 9
    New code: * Text Domain: drophtml

    \includes\post-types\drop.php, Line 7 to 33

    		'name'                  => _x( 'DropHTML', 'Post Type General Name', 'drophtml' ),
    		'singular_name'         => _x( 'Drop', 'Post Type Singular Name', 'drophtml' ),
    		'menu_name'             => __( 'DropHTML', 'drophtml' ),
    		'name_admin_bar'        => __( 'Drop', 'drophtml' ),
    		'archives'              => __( 'Item Archives', 'drophtml' ),
    		'attributes'            => __( 'Item Attributes', 'drophtml' ),
    		'parent_item_colon'     => __( 'Parent Item:', 'drophtml' ),
    		'all_items'             => __( 'List', 'drophtml' ),
    		'add_new_item'          => __( 'Upload Item', 'drophtml' ),
    		'add_new'               => __( 'Upload', 'drophtml' ),
    		'new_item'              => __( 'New Item', 'drophtml' ),
    		'edit_item'             => __( 'Edit Item', 'drophtml' ),
    		'update_item'           => __( 'Update Item', 'drophtml' ),
    		'view_item'             => __( 'View Item', 'drophtml' ),
    		'view_items'            => __( 'View Items', 'drophtml' ),
    		'search_items'          => __( 'Search Item', 'drophtml' ),
    		'not_found'             => __( 'Not found', 'drophtml' ),
    		'not_found_in_trash'    => __( 'Not found in Trash', 'drophtml' ),
    		'featured_image'        => __( 'Featured Image', 'drophtml' ),
    		'set_featured_image'    => __( 'Set featured image', 'drophtml' ),
    		'remove_featured_image' => __( 'Remove featured image', 'drophtml' ),
    		'use_featured_image'    => __( 'Use as featured image', 'drophtml' ),
    		'insert_into_item'      => __( 'Insert into item', 'drophtml' ),
    		'uploaded_to_this_item' => __( 'Uploaded to this item', 'drophtml' ),
    		'items_list'            => __( 'Items list', 'drophtml' ),
    		'items_list_navigation' => __( 'Items list navigation', 'drophtml' ),
    		'filter_items_list'     => __( 'Filter items list', 'drophtml' ),

    \includes\post-types\drop.php, Line 37 to 38

    		'label'                 => __( 'Drop', 'drophtml' ),
    		'description'           => __( 'Drop Html', 'drophtml' ),

    I upload all zh_TW translations to https://translate.wordpress.org/locale/zh-tw/default/wp-plugins/drophtml/, and system push mo and po file named drophtml which doesn’t match your text domain drop.

    If text domain is the same as plugin slug, that can avoid some L10N issues.

    Regards,

    Alex Lion

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author ExpressTech Systems

    (@expresstech)

    I will pass this feedback to our devs, thanks!

    Plugin Author ExpressTech Systems

    (@expresstech)

    By the way, how do you like the plugin so far and what would you like to improve in the plugin.

    Thread Starter Alex Lion (阿力獅)

    (@alexclassroom)

    1. Customize the origin path ‘drop’ to the other path.
    2. There are still many strings that cannot be localized. For example, “the file type that you’ve uploaded is not a ZIP file. Please check them all.”.

    This is an awesome plugin, easy to use and so convenient for hosting landing page.

    Regards,
    Alex Lion

    Plugin Author ExpressTech Systems

    (@expresstech)

    This issue has been resolved and pushed to wp.org repo.

    Plugin Author ExpressTech Systems

    (@expresstech)

    We pushed a new update today, hope you will like it

    * Feature: Customize slug
    * Feature: Text based editor for html, JS and CSS files
    * Feature: Upload files anywhere in the tree.
    * Feature: New directory tree structure

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Text Domain Issue’ is closed to new replies.