SureCookie Fatal Error with Soledad Theme

  • gatsman

    (@gatsman)


    4 days, 18 hours ago

    Hello,

    SureCookie causes a fatal error with the Soledad theme because this function expects 4 arguments:

    public function modify_link_attributes( array $atts, $menu_item, $args, $depth ): array

    but the theme passes only 3.

    Changing it to:

    public function modify_link_attributes( array $atts, $menu_item, $args, $depth = 0 ): array

    fixes the issue.

    Please consider adding this change in a future update.

    Thank you.

Viewing 1 replies (of 1 total)
  • Mohit Sharma

    (@mohitbsf)

    4 days, 16 hours ago

    Hey @gatsman ,

    Mohit here, Product Manager at SureCookie,

    Thank you for reporting this and for sharing the exact cause and suggested fix.

    You’re correct: some custom menu walkers, including the one used by Soledad, call nav_menu_link_attributes with three arguments. Our callback expected a fourth required $depth argument, which could result in a fatal error.

    We have addressed this by making the callback parameters optional and defaulting $depth to 0. The fix is included in our upcoming release.

    Once it will be released, I will personally let you know about it.

    Thanks again for helping us identify this compatibility issue.

Viewing 1 replies (of 1 total)

You must be logged in to reply to this topic.