Plugin Support
Jeff
(@jeffwtsupport)
Hello @istoka ,
Thank you for bringing this to our attention, and for your kind words about the plugin!
We have identified the issues you mentioned regarding the translations in emails, as well as the untranslated strings in the dashboard.
We will be addressing these translation-related issues in an upcoming update.
While translating the plugin (v1.0.2), I found two issues in the React dashboard that prevent some strings from
being translatable:
- Wrong text domain on 19 strings In the React source, 19 __() calls use the text domain wbte-eu-withdrawal-button instead of the registered one
wt-eu-withdrawal-button. Since wp_set_script_translations() only registers wt-eu-withdrawal-button for the
wbte-ewb-admin-dashboard handle, these strings can never be translated. Example — react/src/components/RequestsList.jsx:149:
__( ‘Open Requests’, ‘wbte-eu-withdrawal-button’ ) // should be ‘wt-eu-withdrawal-button’
Affected strings include “Open Requests”, “Approved (30d)”, “No change vs last week”, etc.
- Hardcoded string not internationalized The pagination label is a raw template literal, never wrapped in __(), so it is invisible to wp i18n make-pot and
stays in English. react/src/components/RequestsList.jsx:299-300:
? Showing ${ showFrom }\u2013${ showTo } of ${ total }
: Showing 0 of 0 Could you fix the text domain on those 19 calls and wrap the “Showing …” strings with __() / sprintf() in a future
release? Thanks!
Plugin Support
Jeff
(@jeffwtsupport)
Hello @istoka,
We’re pleased to let you know that the reported translation issues have been addressed in the latest version 1.0.3.
Please download and install the latest version of the plugin to receive the fixes.
Thank you for your support.
Plugin Support
Jeff
(@jeffwtsupport)
Hello @rvola,
Thank you for sharing your findings.
The translation-related issues reported have been addressed in the latest version 1.0.3.
Please download and install the latest version of the plugin to receive the fixes.
We appreciate your contribution.
