• Resolved Alwyn Barry

    (@dramb)


    Sorry to bring up another issue!

    We have 154 different sermon series in our sermon database. But when we use your updated plugin we have only 43 shown when using the sermon-images short code (as below) and some of the images are duplicated to different series titles.

    [sermon-images tax=”wpfc_sermon_series” order=”DESC” orderby=”id” size=”full”]

    I know that the sermon-images shortcode in the original plugin also dropped any series for which it could not find the image, rather than show a default image – something that should be fixed. But it doesn’t seem to be that problem with the reworked plugin. It is not showing even some recent series and when I edit the series there is no image shown in the edit page for series which are not shown or are shown with the wrong image.

    Sorry that I can’t get more detail on this … I can’t work out what the problem causing a series not to show is or what it might be connected with. Let me know if you want to see on our own website. I’ve switched back to the old plugin until we can resolve this issue, because our historic sermon series access is important to us.

    • This topic was modified 1 week, 4 days ago by Alwyn Barry.
Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author mattytap

    (@mattytap)

    Hi Alwyn

    Thanks, this is exactly the kind of report that helps.

    I think I already know what it is. It’s definitely not your data, but an assumption I made in the restoration to 3.0. It looks like the series-image associations from the old plugin’s storage haven’t all carried across into the format the new grid reads (which I had to rewrite during the restoration when I replaced an outdated bundled image library), and where they have, some have mapped onto the wrong series. That would explain both the missing series and the duplicated/wrong images you’re seeing, including the blanks on the series edit screen. It’s a data-mapping issue rather than anything wrong with your sermons themselves.

    I’m confident enough about this that once I’ve confirmed it against your data I should have a fix. It would help to look at your site to confirm it before I post the change to wp though. The forum has no private messaging, so if you’re happy to, could you drop me an email at wp@mattytap.com and we’ll sort out the best way for me to take a look? You’re also right about the original behaviour of dropping a series entirely when it has no image rather than showing a placeholder. I’ll treat that as a separate, smaller bug fix.

    Best wishes
    Mattytap

    Thread Starter Alwyn Barry

    (@dramb)

    Email sent. Let me know if this is helpful. Equally, I’m happy to patch things and try things out for you, if that would be easier. I know enough php to edit sensibly.

    Plugin Author mattytap

    (@mattytap)

    Thanks Alwyn
    Thanks for catching this and great to work with you on this.

    The one-time migration from Sermon Manager was attaching series images to the wrong terms, so most series ended up with no image and dropped out of the grid. It’s fixed in 3.4.2, which rebuilds the affected images automatically from your existing data (and backs up the previous state first), so your full series list comes back on update.

    On your related point, that the grid drops series with no image rather than showing a default: that’s long-standing behaviour from 2.30 (and earlier), and 3.4.2 now lets you change it. Add show_empty=”yes” to [sermon_images] and series with no image of their own will show using your Default Image (Settings > Display), or a neutral placeholder if none is set. It’s opt-in by design, so existing grids aren’t altered unexpectedly on update.

    Best Wishes
    Mattytap

Viewing 3 replies - 1 through 3 (of 3 total)

You must be logged in to reply to this topic.