Settings page doesn’t display properly

  • Resolved sdoweb

    (@sdoweb)


    2 months, 3 weeks ago

    Hello, thank you for this great plugin!

    During my tests, I couldn’t display the “Settings” page correctly; it would appear and disappear with an error message in the console related to “sprintf”.

    To fix the problem, I added a mu-plugin; here’s the code:

    PHP file :

    add_action( 'admin_enqueue_scripts', function () { wp_enqueue_script( 'sitenotes-i18n-fix', plugin_dir_url( __FILE__ ) . 'sitenotes-i18n-fix.js', [ 'wp-i18n' ], null, true ); });

    JS file :
    if ( window.wp?.i18n && typeof window.sprintf === 'undefined' ) { window.sprintf = wp.i18n.sprintf; }

    If it helps 🙂
    Cheers.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Krishna Kant Chourasiya

    (@lushkant)

    2 months, 3 weeks ago

    Hey @sdoweb 🙋‍♂️

    Thank you for your heads up, we just released a patch fixing this issue from inside the plugin. I request you to update to the latest version of the plugin to get the patch.

    I’ll also request you to remove this additional piece of code as it won’t be needed, this code adds the wp-i18n package and another custom script to the entire wp-admin dashboard which may cause higher than usual page load times where it is not needed/used.

    Really appreciate your notification on this, we are working hard on the next updates which will bring some more cool features that you will love.

    If you have a minute to spare and could post this same in the plugin review that would be awesome as it helps us reach more awesome users like you 🙂

    Thread Starter sdoweb

    (@sdoweb)

    2 months, 3 weeks ago

    Thank you for your very quick reply @lushkant

    I’ve temporarily added my code so I can check the plugin settings.
    Thank you for your advice.

    I’ll test the new version immediately and I’ll be sure to leave a comment afterward 🙂

    Edit: issue fixed with the last release ! Thx !

    • This reply was modified 2 months, 3 weeks ago by sdoweb.
    Plugin Author Krishna Kant Chourasiya

    (@lushkant)

    2 months, 3 weeks ago

    @sdoweb glad I could help.

    You can always let me know here for any feature requests or improvements that you yourself would want to see in this plugin 🙂

Viewing 3 replies - 1 through 3 (of 3 total)

You must be logged in to reply to this topic.