Reference to $this in static method

  • Resolved Aurovrata Venet

    (@aurovrata)


    8 years ago

    Dear David

    greetings from south India, hope you’re well!

    I came across the following line of code, a reference to $this in a static method, file /includes/class-mla-settings-documentation-tab.php, line 1000,

    return new WP_Error( 'remove_old_failed', $this->strings['remove_old_failed'] );

    kind regards

    Vrata

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author David Lingren

    (@dglingren)

    8 years ago

    Thank you for your report and for the specifics about the code; very helpful.

    I am traveling and away from my development system for a few more days but I will investigate further when I return home. I will post an update here when I have progress to report.

    Plugin Author David Lingren

    (@dglingren)

    7 years, 12 months ago

    I have found and removed the line of code you referred to. It was unreachable because the line just above it is a “return” statement, so it cannot cause any trouble. I will release the fix in my next MLA version.

    I am marking this topic resolved. Thanks again for alerting me to this issue.

    Thread Starter Aurovrata Venet

    (@aurovrata)

    7 years, 12 months ago

    you’re wc David, thanks for a great plugin 🙂

    It was my code editor that popped up the warning, it never caused any run-time errors as such, but I felt it was good to clean it up.

    have a nice day!

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Reference to $this in static method’ is closed to new replies.