• Resolved digiblogger

    (@digiblogger)


    Would you be so kind to follow WordPress Recommendations and change the load_text_domain function for languages to be places in a “languages” or “langs” or something else folder 😉

    It´s not so nice to have them in root folder and I think it´s just a “/languages/” to change

    https://wordpress.org/plugins/wp-polls/

Viewing 8 replies - 1 through 8 (of 8 total)
  • Thread Starter digiblogger

    (@digiblogger)

    If you provide an email, I would offer the complete german translation

    Thread Starter digiblogger

    (@digiblogger)

    Actually, these strings can not be translated:

    • Total Votes Cast: (in Polls Stats)
    • (default) (in Poll Options)
    • (default gradien) in Poll Options

    Additional: Changing the “@” in Date @ Time outputs a numeric string.

    Plugin Author Lester Chan

    (@gamerz)

    @digiblogger, it is an old plugin and due to legacy code reasons, it has to be in the root. Newer plugins I did are all in the /languages/ folder.

    I have problem understanding your last reply, cannot be translated as in the translation doesn’t have it or the string is not marked for translation?

    For example, “Total Votes Cast:” is translatable https://github.com/lesterchan/wp-polls/blob/master/polls-manager.php#L441

    Thread Starter digiblogger

    (@digiblogger)

    For total votes cast: there is a string in the translation files but the translation does not appear after translated the file.

    For the other two: these strings don’t have a echo output in your code.

    Well, regarding the languages folder…

    It’s just a /languages/ to add:)

    Plugin Author Lester Chan

    (@gamerz)

    I am not too sure why it is not appearing, the code is correct. Try a new POT file https://github.com/lesterchan/wp-polls/raw/master/wp-polls.pot which I generated again.

    Can you point me to the exact line and file of the other two strings?

    Is not that simple. If I changed the directory to /languages/ all users upgrading will get a broken translation since their translation is in the root folder and not languages folder. I have no intention of changing it anytime soon, unless I am rewriting the plugin.

    Thread Starter digiblogger

    (@digiblogger)

    I think your users will not use anything because there translation is overwritten when updating if they have not saved in the global languages directory.

    The two strings are shown top on creating a new poll. In brackets. I don’t know where they are in php files. Maybe these are the folder names in images folder in your plugins root

    Images/default_gradient
    Imagea/default

    Plugin Author Lester Chan

    (@gamerz)

    those are images folder.

    Pablo Guerrez

    (@pablo-guerrez)

    Those strings are not translated because they are “hardcoded” in the settings (polls->templates) 😉

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘Really great Plugin but languages folder ;)’ is closed to new replies.