Query string preservation throws a PHP notice for arrays

  • juiceboxint

    (@juiceboxint)


    11 years, 5 months ago

    I’m getting a notice in debug mode when I try to use arrays in my query string arguments, e.g. ?cat[]=1&cat[]=2:

    Notice: Array to string conversion in /home/public_html/wp-content/plugins/quick-pagepost-redirect-plugin/page_post_redirect_plugin.php on line 1347

    This is in the query-string preservation section of the code: the $_GET variable properly converts it to a PHP array as expected, but the code that follows (line 1347) isn’t prepared to handle arrays so it chokes when you try to recreate the query string.

    I’m working on a fix for this right now which (if successful) I’ll post shortly – but just wanted to bring this to your attention.

    https://wordpress.org/plugins/quick-pagepost-redirect-plugin/

Viewing 1 replies (of 1 total)
  • Thread Starter juiceboxint

    (@juiceboxint)

    11 years, 5 months ago

    This seemed to do the trick, replacing line 1347:

    foreach($_GET as $key => $value) {
	// Handle cases where QS argument is an array - for instance, "?cat[]=1&cat[]=2"
	if (is_array($value)) {
		foreach ($value as $k => $v)  {
			$useURLQS[] = $key . '[]=' . $v;
		}
	} else {
		$useURLQS[] = $key . '=' . $value;
	}
}

    I haven’t tested it with actual redirects that use query strings. When I noticed it, it was throwing the error any time there was an array in the query string even if the page wasn’t being redirected. This fixed my immediate problem, so I’m calling it good on my end, but it should probably be tested a bit more before rolling it into the next release.

    Thanks!

Viewing 1 replies (of 1 total)

The topic ‘Query string preservation throws a PHP notice for arrays’ is closed to new replies.