• Resolved Tessa (they/them), AuRise Creative

    (@tessawatkinsllc)


    Hello, I’m not sure I understand the process you want contributors to follow.

    In the long description of your plugin here, you send potential contributors to this page on your website which in turn has links to your GitHub repo and coding standards.

    I wanted to contribute a feature, so when you closed my pull request with the labels to post it to the support forum or open an issue, it doesn’t make sense to me. Should I open an issue that describes my interest for wanting the feature and then submit the code that “fixes” it? I’m just confused and would like some clarification on what I should do to follow your preferred process in this case. Even if you’re not interested and it ends up not getting added, I want to make sure I’m asking correctly.

    Thanks!

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Takayuki Miyoshi

    (@takayukister)

    Please read the Contributing by reporting issues section again. As I’ve written in it, creating an issue is always recommended, except in cases where it’s about a trivial matter like typo correction. I don’t recognize a pull request as a place to discuss something. I won’t review a pull request if it’s not connected to any open issue.

    By the way, I suppose you are talking about this pull request. I added to it the “open issue no pr” label because no related issue has been created yet, “post it to the support forum” label because I thought what you are trying to fix should be discussed in the support forum, and “not interested” label because I’m not interested in the topic (to be honest, I’m sorry) so I won’t merge your patch either way.

    Thread Starter Tessa (they/them), AuRise Creative

    (@tessawatkinsllc)

    “not interested” label because I’m not interested in the topic (to be honest, I’m sorry)

    No need to be sorry, no offense taken. Perfectly fine to not be interested 🙂

     “post it to the support forum” label because I thought what you are trying to fix should be discussed in the support forum

    Yep! That’s why I followed-up here instead of there.

    Thank you for clarifying!

Viewing 2 replies - 1 through 2 (of 2 total)

You must be logged in to reply to this topic.