Prediction rule

Hi Reinis,

I get the idea: you want to add some disadvantage to the top players so it (hopefully) makes it easier for the lower ranked players to catch up.

I have to think about it for a bit, because both are not possible right now. And I foresee some problems because it would require to load the ranking on some parts of the plugin where I would rather not add this extra sql query (because it is the slowest query in the plugin). So my first thought would be to not include it in the vanilla plugin. But maybe as an extension.

I think having the variable lock time is the easiest as it would only require one place to change the code (and then extend on that part with an extension that overwrites the setting). Checking for multiple saves also requires a database change to store the time when a save was done by the player. And I also do not like the idea of locking the form when a player accidentally saves it with the wrong numbers.

I played around a bit with the idea and came up with the following extension.

This extension also requires a hook in the Football_Pool_Matches class to work. I will add the hook in my next version of the plugin (v2.9.6 or higher), but to immediately start using the extension you’ll have to change the following line in that class file:

$this->lock = Football_Pool_Utils::get_fp_option( 'maxperiod', FOOTBALLPOOL_MAXPERIOD, 'int' );

to:

$this->lock = apply_filters( 'footballpool_matches_lock_maxperiod',
				Football_Pool_Utils::get_fp_option( 'maxperiod', FOOTBALLPOOL_MAXPERIOD, 'int' ) );

You can change the lock times to your liking via the array definition in the extension. You can add as much ranks as you wish, e.g. (example is for top 3 players):

private static $variable_lock_times = [
	// format of array: ranking (int) => seconds for lock time (int)
	1 => 1 * HOUR_IN_SECONDS,
	2 => 45 * MINUTE_IN_SECONDS,
	3 => 30 * MINUTE_IN_SECONDS,
];