Possibility to disable CSS adding to the head

Resolved charli_polo
(@charli_polo)

13 years ago

Hi there,

Some theme requires that you register stylesheet through their own function, in order to minimize conflicts.

I guess you know what I mean, as I saw some exception in your code so that thesis editor pages wouldn’t get the bootstrap css (line 157 of hlt-bootstrapcss.php).
if ( !is_admin() && !in_array($GLOBALS['pagenow'], array('wp-login.php', 'wp-register.php')) && !isset( $_GET['thesis_editor'] ) ) {

I would be nice to have the possibility to disable the output within the head.
Second wish would then to have a nice access to $aIncludesList (the list of CSS files to include) in order to register those files to the theme.

Do you think this makes sense ?
Thx for this great plugin.

http://wordpress.org/extend/plugins/wordpress-bootstrap-css/

Viewing 9 replies - 1 through 9 (of 9 total)

Plugin Author Paul
(@paultgoodchild)

13 years ago

Hey,

Yep, this is something that’s been on the to-do for the longest time… making the plugin work with both the standard includes methodology, and original method.

The original method was chosen not due to our ignorance of how to include, but because some themes just don’t play well with the includes and don’t let you include when and where you want.

I think I’ll give a serious stab at this after or coming up to version 3.0 of bootstrap – it’s quite an overhaul.

When you say you’d like access to the includes list, how exactly would you like to see that provided – suggestions welcome! 🙂

Thanks,
Paul.

Plugin Author Paul
(@paultgoodchild)

13 years ago

Hey,

Alright, I’ve done some major code reworking and there is a new option to include the CSS using WordPress’ enqueue functions.

It’s a big change, and I’ve tested it, but would you like to download the code pre-release and install it on your site to see that this works as expected for it?

You can get the latest version here: http://downloads.wordpress.org/plugin/wordpress-bootstrap-css.zip

If you can’t no problem, but it would really help to have a little testing before release if possible. Let me know sure.
Ta
Paul

Thread Starter charli_polo
(@charli_polo)

13 years ago

Excellent news !

I will test your release and let you know asap.

Thread Starter charli_polo
(@charli_polo)

13 years ago

Seems like your link does not provide any significant change.

Should I try the dev version from the svn ?

Thread Starter charli_polo
(@charli_polo)

13 years ago

Ok, after a few tries, I tested this version.
Looks fine to me, no bug discovered at the moment.

A few suggestions:
1/ The option name and description are not very explicit.
2/ This still does not give the possibility to include CSS by another way (like through a custom function of a theme). Actually, as your new version solves my issues, I don’t need to do so, so I am not sure it’s needed anyway. I guess it’s also possible to use remove_action in order to disable totally the last line of your hlt-bootstrapcss.php. In this case, getting an easy access to $aIncludesList would still be required.

So overall: Problems solved 🙂

Plugin Author Paul
(@paultgoodchild)

13 years ago

I’ll tweak the description to try and make it clearer.

As for access to the includes list, I’d need to implement a filter for that, and while I don’t think it’d be too much work to get that running, I’ll save it for the next release I think, so as not to delay, and potentially introduce more scope for error.

Again, thanks for testing 🙂

Plugin Author Paul
(@paultgoodchild)

13 years ago

Just letting you know it’s been released – I’ve updated the text of the option a little. I hope it reads better.

Would you mind taking a second and giving a review of the plugin? This helps lend legitimacy to the plugin.

Many thanks for your suggestions and help to get the new release out 🙂
Cheers,
Paul.

Thread Starter charli_polo
(@charli_polo)

13 years ago

Let’s not reverse things here… You are the one coding, so I am the one saying Thx !

I’l review the plugin.

Cheers,
Charlie.

Plugin Author Paul
(@paultgoodchild)

13 years ago

hehehe, it’s a team effort 😉
Thanks for the review too, appreciate that.
P.

Viewing 9 replies - 1 through 9 (of 9 total)

The topic ‘Possibility to disable CSS adding to the head’ is closed to new replies.