Popup not always shown

  • Resolved christer_f

    (@christer_f)


    2 months, 1 week ago

    Hello,

    I have noticed that the popup does not always work. To test things I made a change to the function should_show_popup in class-popup-system.php to always return true. This means that the popup will always be shown regardless if the SHOWN_COOKIE has been set or not.

    On some pages the popup is shown, on some not, and switching between Safari and Chrome, it appears that there are more problems with Chrome. I wonder if it is not a timing issue in javascript, that something should wait for the page to be fully loaded before doing its job. Maybe the javascript function init in class-popup-system? (although it seems you’re handling that around line 350…)

    christer

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author MaxtDesign

    (@slaacr)

    2 months, 1 week ago

    Thanks for reporting this

    It looks like the JavaScript that controls the popup was trying to initialize before the popup HTML had finished rendering on the page. Chrome’s faster JavaScript engine made this more noticeable there, but it could happen on any browser depending on load speed.

    I’ve changed how the popup initializes – now it waits for the full page load instead of just the DOM ready event. This ensures the popup HTML is definitely there before the JavaScript tries to interact with it.

    This fix is going live in version 1.7.2, which is currently being tested.

    Really appreciate you taking the time to report this with such detail – made tracking down the issue much faster.

    Thread Starter christer_f

    (@christer_f)

    2 months, 1 week ago

    OK. Thanks for your immediate reaction! Great support!

    What I have done as a temporary fix is to call a different function around lines 350 instead of init. That different function calls init after a delay of 200 msecs, and now things work (and the short delay before showing the popup is not really a problem)

    Plugin Author MaxtDesign

    (@slaacr)

    2 months ago

    I appreciate your efforts on this Christer. All update have been posted.

Viewing 3 replies - 1 through 3 (of 3 total)

You must be logged in to reply to this topic.