[Plugin: WP Mail SMTP] Enhancements

  • wjm

    (@wjm)


    15 years, 9 months ago

    Hi Callum:
    here are a few comments to improve your script.

    1. Password Field should be password not text,
    so i changed,

    <td><input name="smtp_pass" type="text" id="smtp_pass" value="<?php print(get_option('smtp_pass')); ?>" size="40" class="code" /></td>

    for

    <td><input name="smtp_pass" type="password" id="smtp_pass" value="<?php print(get_option('smtp_pass')); ?>" size="40" class="code" /></td>

    2. I think “Email” is a bit general for the menu item in Options,
    i think it would be better to have something like “SMTP Email” if “WP SMTP Email” is too much.
    So i changed,

    add_options_page(__('Advanced Email Options', 'wp_mail_smtp'),__('Email', 'wp_mail_smtp'),'manage_options',__FILE__,'wp_mail_smtp_options_page');

    for

    add_options_page(__('Advanced Email Options', 'wp_mail_smtp'),__('SMTP Email', 'wp_mail_smtp'),'manage_options',__FILE__,'wp_mail_smtp_options_page');

    thanks for your work,
    just giving back a little bit.
    – wjm

Viewing 3 replies - 1 through 3 (of 3 total)
  • Callum Macdonald

    (@chmac)

    15 years, 9 months ago

    Thanks for sharing.

    Point 1 has been discussed and the suggestion rejected.

    Point 2 is the first time I’ve heard it. Personally, I’d like to see this plugin redundant because SMTP options are included in core. In which case, Options > Email seems like the most sensible name. I’m not inclined to change the existing menu name right now, I think it could cause more confusion than benefit.

    Thread Starter wjm

    (@wjm)

    15 years, 9 months ago

    about Point no. 1,

    i think it adds some level of security as the password is not exposed to pricking eyes.
    specially if people use their personal email account for this purpose.

    It’s like storing passwords in your web browser.
    Password is there stored in a database in plain text.. but that doesnt mean that every time you check your email password needs to be displayed on screen.

    just my two cents.
    – wjm

    Callum Macdonald

    (@chmac)

    15 years, 9 months ago

    In my opinion, better to be completely transparent that the password is stored in plain text, than give the illusion of security that does not exist. The way it stands, users can see that their password is stored in plain text, it’s right there on the screen. 🙂

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘[Plugin: WP Mail SMTP] Enhancements’ is closed to new replies.