[Plugin: Slideshow Gallery Pro] Chrome opacity

  • guillaumev

    (@guillaumev)


    15 years, 2 months ago

    Hi,

    I’ve noticed that the opacity of the images does not work well in Chrome. For example, open your site http://cameronpreston.com/projects/plugins/slideshow-gallery-pro/ and you will see that the images do not show properly.

    To fix it, in js/gallery.js, function TINY.alpha, replace


    tw:function(e,a,d,s){
    var o=Math.round(e.style.opacity*100);
    if(o==a){clearInterval(e.ai)}else{var n=o+Math.ceil(Math.abs(a-o)/s)*d; e.style.opacity=n/100; e.style.filter='alpha(opacity='+n+')'}
    }

    by


    tw:function(e,a,d,s){
    var y = e.style.opacity.replace(',', '.');
    var o=Math.round(parseFloat(y)*100);
    if(o==a){clearInterval(e.ai)}else{var n=o+Math.ceil(Math.abs(a-o)/s)*d; e.style.opacity=n/100; e.style.filter='alpha(opacity='+n+')'}
    }

    Would be nice to see this bug fix integrated in the next version of the plugin 🙂

    http://wordpress.org/extend/plugins/slideshow-gallery-pro/

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author cpres

    (@cpres)

    15 years, 2 months ago

    Do you see the images as a little washed out due to a little extra transparency?

    Btw, thanks for the easy code switch. I’ll upgrade this in the next version. Cheers

    Plugin Author cpres

    (@cpres)

    15 years, 2 months ago

    Damn, it looks like your code is taking out IE. And I tested it on my Chrome, and I don’t have a “,” in my e.style.opacity

    Makes me wonder if its something with your Chrome, or if its something that definitely needs to be in the slideshow

    Thread Starter guillaumev

    (@guillaumev)

    15 years, 2 months ago

    Hi,

    Very interesting ! To be honest, I had tested on Chromium, not on Chrome, because I believed that the source codes were the same, but now I did some more tests and I have some interesting results:

    – on IE, yes, my code doesn’t work (sorry, my bad, I had not tested on IE)
    – on Chrome, without my modification or with my modification, it works either way
    – on Chromium, it only works with my modification

    I’ll look a little bit further and will keep you updated

    Thread Starter guillaumev

    (@guillaumev)

    15 years, 2 months ago

    All right so this code:

    set:function(e,a,s){
    e=typeof e=='object'?e:tid(e); var o=e.style.opacity||TINY.style.val(e,'opacity'),
    d=a>o*100?1:-1; e.style.opacity=o; clearInterval(e.ai); e.ai=setInterval(function(){TINY.alpha.tw(e,a,d,s)},20)
    },
    tw:function(e,a,d,s){
    var y = e.style.opacity;
    if (typeof y == 'string') {
    y = e.style.opacity.replace(',', '.');
    }
    var o=Math.round(parseFloat(y)*100);
    if(o==a){clearInterval(e.ai)}else{var n=o+Math.ceil(Math.abs(a-o)/s)*d; e.style.opacity=n/100; e.style.filter='alpha(opacity='+n+')'}
    }

    seems to work everywhere (I haven’t tested on Opera though).

    Just to give more details, the chromium version I used was running on Ubuntu Linux, while the Chrome browser I used was running on Windows XP. So I believe the difference I saw between Chrome and Chromium was either due to:
    – a difference in the source code between Chrome and Chromium
    – the OS difference (one on Linux, one on Windows)

    I’ll inform the Chromium project about that, maybe they’ll have an explanation…

    Thread Starter guillaumev

    (@guillaumev)

    15 years, 2 months ago

    I just posted an issue in Chromium: http://code.google.com/p/chromium/issues/detail?id=71174

    Plugin Author cpres

    (@cpres)

    15 years, 2 months ago

    Great work, I’ll test this out soon! And now I’ll be able to say it works on the Chromium browser (which I certainly don’t test for atm)

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘[Plugin: Slideshow Gallery Pro] Chrome opacity’ is closed to new replies.