Plugin compatibility with child themes and multilang

  • Resolved Tzvook

    (@tzvook)


    7 years, 4 months ago

    Hello
    I’m testing the plugin

    For the plugin compatibility with child themes
    line 176in the file:
    recipepress-reloaded\admin\views\rpr-options-page\rpr-options-page-appearance\class-rpr-options-page-appearance-layout.php
    should be:
    $baseurl = get_stylesheet_directory_uri(). '/rpr_layouts/'. $file;
    instead of
    $baseurl = get_template_directory_uri(). '/rpr_layouts/'. $file;

    One more thing I noticed, but still didn’t solve is the index page ( result of [rpr-recipe-index] ) that is incompatible with non-Latin languages: it’s encoding is not UTF8 without BOM + A-B-C-D-E-F-E is not multilang 🙁 )

    • This topic was modified 7 years, 4 months ago by Tzvook.
Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Kemory Grubb

    (@w33zy)

    7 years, 4 months ago

    Hello @tzvook

    I took over development of this plugin a while ago and in doing so I’ve completely rewritten the plugin.

    So because you are testing the features of the plugin for possible usage, is it possible I can send you the link to a Github repo with the updated plugin?

    Thread Starter Tzvook

    (@tzvook)

    7 years, 4 months ago

    2 solutions for Multibyte langs (non-Latin ones):

    recipepress-reloaded\public\layouts\rpr_default\recipe_index.php
    Edit line 30 and change it from

    $first_letter = substr( normalize_special_chars( $post->post_title ), 0, 1 );

    to

    $first_letter = mb_substr( normalize_special_chars( $post->post_title ), 0, 1 );

    There are probably additional places that require the “mb_substr” replacement ..

    ——————————————————
    in the file recipepress-reloaded\public\rpr_template_tags.php lines 2299 and after – the whole “Alphabet navigation bar for listings” should be changed for non-latin languages

    Thread Starter Tzvook

    (@tzvook)

    7 years, 4 months ago

    Sorry @w33zy … didn’t saw your answer and posted 🙂
    Of course … I’ll be glad to …

    tzvookAToutlook.com

    • This reply was modified 7 years, 4 months ago by Tzvook.
    Plugin Author Kemory Grubb

    (@w33zy)

    7 years, 4 months ago

    As I had mentioned, I have rewritten the plugin so those files now longer exist. Those variable now reads as: $first_letter = is_numeric( mb_substr( remove_accents( strtoupper( $post->post_title ) ), 0, 1, 'utf-8' ) ) ? '#' : mb_substr( remove_accents( strtoupper( $post->post_title ) ), 0, 1, 'utf-8' );

    Plugin Author Kemory Grubb

    (@w33zy)

    7 years, 4 months ago

    A user for one of my other plugin brought the issue with substr() and multibyte characters to me this morning here https://wordpress.org/support/topic/rcno-recent-review/

    Thread Starter Tzvook

    (@tzvook)

    7 years, 4 months ago

    Yep … she use Hebrew too ( multibyte )
    You can send the link to a Github repo to tzvookAToutlook.com

    Plugin Author Kemory Grubb

    (@w33zy)

    7 years, 4 months ago

    The repo is available at https://gitlab.com/w33zy/recipepress-reloaded

    Thread Starter Tzvook

    (@tzvook)

    7 years, 4 months ago

    10x … will try it tomorrow

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘Plugin compatibility with child themes and multilang’ is closed to new replies.