Plugin Causing Javascript Error in WordPress Admin

After posting my previous message I enabled WP_DEBUG and WP_DEBUG_LOG.

In doing so I’ve been able to identify that the plugin is throwing the following php errors (via wp-content/debug.log).

The called constructor method for WP_Widget is deprecated since version 4.3.0! Use __construct() instead.

has_cap was called with an argument that is deprecated since version 2.0! Usage of user levels by plugins and themes is deprecated. Use roles and capabilities instead.

Further info on these errors can be found here & here.

It appears the plugin is using outdated WordPress functions and needs to be updated for the latest version. Are you doing your testing for the javascript error on the latest version of WordPress?

Additionally I’m getting the following error when deactivating then reactivating the plugin.

The plugin generated 308 characters of unexpected output during activation. If you notice “headers already sent” messages, problems with syndication feeds or other issues, try deactivating or removing this plugin.

Using this tool (with WP_DEBUG enabled), I’ve been able to identify the source of the ‘unexpected output’ error in the plugin code, as below.

Notice:  Undefined variable: wpdb in /wp-content/plugins/joan/joan.php on line 20

Notice:  Trying to get property of non-object in /wp-content/plugins/joan/joan.php on line 20

Information on declaring wpdb as a global variable can be found here.

If required, more information on the ‘unexpected output’ error can be found here.

I would encourage you to enable WP_DEBUG and WP_DEBUG_LOG in your wp-config file and have a look over the deprecated functions currently being used in the code. There’s quite a few errors with the plugin that need to be resolved.

Here’s a thread where other users have exemplified how to updated the has_cap function, and another here.

I see you’ve resolved the ‘unexpected output’ error with the latest update. Thanks for that.

The javascript error in the admin still persists though. It will be interesting to see whether the resolution of the deprecated function has_cap resolves that issue.

Also, with the updated version of the plugin you’ve accidentally wrapped each list of shows in the front end program guide with <li class=”joan-schedule”> tags rather than <ul class=”joan-schedule”> tags. Could you fix that up?

One last thing, any chance we can include my provided code for displaying the programs on air today in the plugin? I’m having to manually include this with each update.

Thanks for the updates ganddser.

Unfortunately the fix mentioned above for the incorrect list markup wasn’t applied.

The code that needs to be amended is in joan.php on lines 165 & 179.

Line 165 needs to be changed to the following,

$output .= '<ul class="joan-schedule">';

Line 179 needs to be changed to the following,

$output .= '</ul>';

Could you apply these updates? Thanks.

Thanks ganddser, but the list markup is still incorrect.

You made the correct changes I mentioned above, but you also changed some li tags (to uls) that needed to stay as is.

You’ll need to amend the plugin again.

In joan.php line 176 needs to be changed to the below.

$output .= '<li><strong>'.$startClock.'</strong> - <strong>'.$endClock.'</strong>: '.$showName.'</li>';

Also on line 223 I missed a closing ul tag which we’ll need to add, as below.

$output .= '</ul>';

Thanks for everything gandsser.

As you’ve advised, I’d like to look into your hosting. Do you have a test/dev WordPress site set up on it that I could log into and have a look around? I’d like make sure that everything works the way I need it to before moving forward.