plugin breaks/strips html in menu title

  • rcain

    (@rcain)


    8 years, 10 months ago

    Hi,

    Useful plugin. Thanks.

    One problem I encountered: (v 4.3.0.3 of plugin) i needed to insert an html line break ( br ) tag in my menu title – the plugin responded by no longer processing the proper awesome font substitutions on the menu item.

    i traced the problem back to:

    file: n9m-font-awesome-4.php
    line: 121

    – it appears the regex in pregmatch was choking on any html in menu text. So I fixed it up:

    changed from:

    '/(<li[^>]+class=")([^"]+)("?[^>]+>[^>]+>)([^<]+)<\/a>/',

    changed to:

    '/(<li[^>]+class=")([^"]+)("?[^>]+><a[^>]+>)(.*)<\/a><\/li>/',

    i’m quite surprised no one seems to have come across this before. i wonder if you could apply my fix your core code?

    many thanks.

    Rob Cain

    https://wordpress.org/plugins/font-awesome-4-menus/

Viewing 1 replies (of 1 total)
  • Plugin Author Joe Ponzio

    (@new-nine)

    8 years, 10 months ago

    Definitely. I want to test it out a bit, but we’ll be sure to include it in a future update. Thanks for catching and patching it!

Viewing 1 replies (of 1 total)
  • The topic ‘plugin breaks/strips html in menu title’ is closed to new replies.