Thanks for taking the time to report BackuPs. If this is something we can resolve we would love to.
Could you elaborate a little bit? What themes are you seeing this on, and what URL? I would like to try and reproduce this so that we can then see about fixing it. If id is not being set in some circumstance, we need to figure out what the circumstance are. Thanks!
– Brook
Hi Brook,
This would mean i would have to give you access to my wordpress as the error only shows in the admin area when debug mode is turned on.
The code fix is very straight forward as it checks if $current_screen has any value at all. It will not harm the working implementing as given as it wont affect normal working of your plugin. It will just prevent a notification warning in a premium theme which has build in support for custom post types that are not their own such as your plugin.
It popsup in shortcode generator screens of the theme itself or any other plugin which uses ajax to popup a screen to generate content.
Okay I follow. Thanks again.
Just so you know, our plugin is open source. If you ever want to quickly submit something like this, feel free to submit a pull request. It’s all hosted on github: https://github.com/moderntribe/the-events-calendar
Cheers!
– Brook
Hi
In the new build the issue is not fixed as the suggested code is not added. Do you want me to go to github in order to get that code snippet added so the plugin does not conflict with ajax popup screens themes have to generate their shortcode?
i really dont understand why the provided fix was ignored as it’s a logical to check for if a variable has been set before questioning it’s value.
Best regards,
BackuPs
I agree it is logical, and something we are in the habit of doing throughout our code for obvious reasons. Our plugin has a code freeze almost two weeks before release to allow time for the QA team to do their thing. Your report here did not make it in time. Actually though, most of the time all bugs and features are planned out at the beginning of the release cycle, giving devs time to work on them. Small stuff like this is occasionally slipped in sooner, but usually only if it is a high priority. I hope you can understand, but a notice which has only happens when you have debug enabled, a certain theme, and click the right box, is naturally not as high of priority.
I have logged this and it will be fixed. Quite possibly in our next release. If you wish to submit a pull request on github instead, that totally works too. I am not sure how often our lead dev reviews those, but I am sure it happens at least once a release if not more frequently. That would be a pretty sure fire way to get it included in the next release if you are in a hurry.
Please do not take any of this to mean I unappreciative for your assistance. I do really am happy you took the time to make a bug report. There is just a certain bureaucracy that is necessary for maintaining an open source plugin with a large in-house development team. It helps prevents bugs and keeps the developers lives manageable, but it surely slows things down a bit. Thank again!
– Brook
Hello,
Thank you again for bringing this issue to our attention. We’re happy to say that we have added a fix for this into our upcoming version 3.11 release. Keep an eye on your Updates page for the new version. If you have any trouble with the update (or are still seeing this problem after you update) please start a new thread and we’d be happy to help out.
Thank you for your patience while we got this release ready to go!
Best,
Leah
and the rest of The Events Calendar team
