Please add PRIMARY KEYs to CREATE TABLE
-
Hi!
Could you please add a PRIMARY KEY to the TEMPORARY TABLEs created by this plugin?
https://plugins.trac.wordpress.org/browser/pw-bulk-edit/trunk/includes/sql-builder.php#L113
https://plugins.trac.wordpress.org/browser/pw-bulk-edit/trunk/includes/sql-builder.php#L153
This will ensure that the plugin continues to work on WordPress.com (and elsewhere that requires primary keys to exist). Based on what the code is doing I think it should be as simple as adding PRIMARY KEY to the post_id field in both cases.
Additionally, but unrelated. I would suggest changing the filed definitions to match the tables that are selected from. For example, the wp_posts table uses bigint(20) unsigned for the ID column but this temporary table uses INT for post_id which means if someone has IDs larger than 2147483647 in their wp_posts table this code will not work as expected.
Please let me know if you have any questions!
The topic ‘Please add PRIMARY KEYs to CREATE TABLE’ is closed to new replies.
