PHP-DI upgrade

  • Resolved Thomas

    (@tsteur)


    5 years, 4 months ago

    Hi, this is Thomas from Matomo Analytics.

    We recently pushed an update of our plugin to be compatible with PHP 8 where we upgraded PHP DI to 6.3.0. However, this caused some issues see https://wordpress.org/support/topic/critical-error-after-upgrade/ where our plugin is now incompatible with Cookiebot as you are using an older version of php-di.

    Was just wondering if you’re planning to upgrade PHP-DI to 6.X as well in order to be compatible with PHP 8? This would fix the issue for our users. We had actually sponsored a fix to get PHP-DI compatible with PHP8 while still supporting PHP 7.2 and newer see https://github.com/PHP-DI/PHP-DI/issues/727#issuecomment-707168802 Otherwise the next PHP DI release would have only supported PHP 7.4 or so.

    Feel free to mark the issue as resolved. Just wanted to check in.

Viewing 6 replies - 1 through 6 (of 6 total)
  • mickna

    (@mickna)

    5 years, 3 months ago

    Any news on this?

    Plugin Author monocode

    (@teamappsaloon)

    5 years, 3 months ago

    @tsteur which version of Matomo Analytics caused the critical error? We tried to reproduce the issue with version 4.1.1 as well as 4.1.0, but we could not reproduce this issue. Can you also explain where the issue occurs? Is it in the front-end or in the back-end? Any specific page or steps to reproduce?

    Kind regards,

    Team AppSaloon

    Thread Starter Thomas

    (@tsteur)

    5 years, 3 months ago

    Hi there, you can reproduce it using the 4.0.0 version when you go to for example Matomo Analytics -> System report page.

    In the newer versions we automatically put our plugin into some “safe mode” and disable like all the functionality when cookiebot is enabled to avoid errors. This is why you cannot reproduce it there.

    In newer versions you could reproduce it by returning false here: https://github.com/matomo-org/wp-matomo/blob/4.1.1/classes/WpMatomo.php#L173

    akku123243tuzi

    (@akku123243tuzi)

    5 years ago

    @tsteur Cookiebot just released a new version with a fix. Can you remove them from the Matomo incompatibility list? 🙂

    Thread Starter Thomas

    (@tsteur)

    5 years ago

    That’s great to hear @akku123243tuzi ! I just did that and it’ll be included in the next release. Thanks for this.

    Thread Starter Thomas

    (@tsteur)

    5 years ago

    Marking it as resolved.

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘PHP-DI upgrade’ is closed to new replies.

  • 6 replies
  • 4 participants
  • Last reply from: Thomas
  • Last activity: 5 years ago
  • Status: resolved