Payment instructions appearing twice

Resolved

(@akshat05)

Hi,

I used the following snippet to set the COD orders on hold, it’s working fine but the instructions (Pay with cash upon delivery.) are written twice on the thank you page and in emails.

add_filter( 'woocommerce_payment_gateways', 'my_core_gateways',30,1 );
function my_core_gateways( $methods ) {
	$methods[] = 'WC_Gateway_COD_custom';
	return $methods;
}

class WC_Gateway_COD_custom extends WC_Gateway_COD {
	public function process_payment( $order_id ) {

		$order = wc_get_order( $order_id );

		// Mark as on-hold
		$order->update_status( 'on-hold', __( 'Payment to be made upon delivery.', 'woocommerce' ) );

		// Reduce stock levels
		$order->reduce_order_stock();

		// Remove cart
		WC()->cart->empty_cart();

		// Return thankyou redirect
		return array(
			'result'    => 'success',
			'redirect'  => $this->get_return_url( $order )
		);
	}
}

Kindly help me in resolving this.

Thanks

Viewing 6 replies - 1 through 6 (of 6 total)

jessepearson
(@jessepearson)

Automattic Happiness Engineer

7 years, 10 months ago
@akshat05 I believe you are trying to make all COD orders go on-hold, correct? If so, this is a much easier way:
```
function jp_set_cod_to_on_hold( $status, $order ) {
	return 'on-hold';
}
add_filter( 'woocommerce_cod_process_payment_order_status', 'jp_set_cod_to_on_hold', 10, 2 );
```
Thread Starter akshat05
(@akshat05)

7 years, 10 months ago

Thanks @jessepearson, worked like a charm 🙂

I want all the orders to set on hold irrespective of payment method, I’ll do some offline validation then update the status manually, please can you help me with it?

Thanks

jessepearson
(@jessepearson)

Automattic Happiness Engineer

7 years, 10 months ago

@akshat05 We are able to help with simple snippets like the one I provided, anything beyond that you would need to hire a developer for assistance.

Thread Starter akshat05
(@akshat05)

7 years, 10 months ago

Hi @jessepearson,

I can do modifications by extending class or overriding functions, just wanted to know if there’s any filter which can do that 🙂

Thanks

jessepearson
(@jessepearson)

Automattic Happiness Engineer

7 years, 10 months ago

@akshat05 There may be, but let me point out why it may be a bad idea. This is the function that actually captures the payment through the PayPal standard gateway included with WooCommerce:
https://github.com/woocommerce/woocommerce/blob/3.4.3/includes/gateways/paypal/class-wc-gateway-paypal.php#L396-L429

If you read the note on line 392, you will see that it states this is triggered on a change from on-hold to processing/complete. These action hooks can be seen on lines 73-74.

This is just for this specific gateway, but others probably work in a very similar fashion, that they do not actually capture payment until the order itself changes status to processing.

It may be better to get a plugin that supports additional order statuses and use that to implement what you are working on. A few are listed here:
https://www.google.com/search?q=woocommerce+order+statuses&oq=woocommerce+order+statuses

Thread Starter akshat05
(@akshat05)

7 years, 10 months ago

Thanks @jessepearson,

I have done exactly same for PayPal.

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘Payment instructions appearing twice’ is closed to new replies.

Tags