I solved this:
return "<a class='osd-sms-link' data-platform='{$platform}' target='{$target}' title='{$button_title}' href='#' data-url='{$url}' rel='nofollow'>";
}
the href=” “ aren’t set. i add {$url} to this.
Ferrmolina,
We intentionally removed the href attribute. All link opening is handled in JS (due to having to use window.open() to open a new window for links) so removing the href is completely fine.
We had to remove the href attribute due to a conflict with Pinterest’s official pin it script. Some users wanted to have OSD Social Media Sharing as well as Pinterest’s official script. Pinterest will hijack any link with an href of “www.pinterest.com/pin/create/button”, change the image and completely remove all attributes (so our pinterest button was being taking over by the official script even though we have nothing to do with it). The best solution for us was to simply move the href attribute (since we weren’t really using it anyway) to a data-url attribute.
The fix you made will add an href attribute, yes, but it will cause your pinterest button to mess up if you ever load the offical pinterest script and it adds no additional functionality. It will also be overwritten on plugin updates.
If not having an href is in fact messing up your site, please let me know and we will add a setting to make that change optional.
I hope this information was helpful!
Hi OSDWEBDV, in my case i’m no use the pinterest button 🙂
I change this, and the href for a whatsapp button.
Thanks!
Ferrrmolina,
Great! Good ratings appreciated!
