Missing jquery ui widget.min.js
-
Hi all,
A recent update broke the Matomo reporting on my site.
I’m not exactly sure what, but it could be the WP upgrade to 5.6.wp-includes/js/jquery/ui/widget.min.js seems to be missing.
Has anyone else encountered this?
Kind regards,
Timmmy
-
Hi all,
Justed checked the backups, and going from the timestamp it’s indeed caused by the WP upgrade.
I’ll make a separate post for that…Hi @timherinckx
this file should exist in your WP 5.6 installation indeed. It should be in
wp-includes/js/jquery/ui/widget.min.js.I suppose we can mark this issue as resolved? Maybe another update WP update helps to fix the issue?
Hi @tsteur ,
Thanks for the feedback!
I doublechecked the official .zip download, but the file also seems to be missing there.
Then filed a bug on track https://core.trac.wordpress.org/ticket/52259.Feedback of the wordpress team is that these files have indeed been removed:
The latest version of jQuery UI does not have separate files for these two components, they are part of jQuery UI Core, so just enqueuing jquery-ui-core will cover all 3 of them.
There is a back-compat entry for them as well, so this change shouldn’t cause any breaking changes if plugins are using WordPress’ script enqueue system (wp_enqueue_script) properly, so I would reach out to the plugin in question if their plugin isn’t working right now. A quick cursory look shows that the yare not doing this, so this is a plugin issue 🙂
Thanks for this @timherinckx very appreciated. It seems when I updated to 5.6 WP did not delete the older files which is how I did not notice it. I’ve now manually removed these files and noticed the Matomo UI still works though even the files don’t exist. Can you confirm this?
I’ve prepared a fix for this in https://github.com/matomo-org/wp-matomo/pull/408/files
If you wanted to test it, you could replace the content of the file
wp-content/plugins/matomo/plugins/WordPress/WpAssetManager.phpwith this content: https://raw.githubusercontent.com/matomo-org/wp-matomo/70ca674806c8fe3acd3d188b39d019033641cd01/plugins/WordPress/WpAssetManager.phpThanks again for bringing this up and creating the WP issue.
Hi @tsteur,
Thanks for the quick follow-up.
I’ve tried to test, but I’m only getting more confused :pOn my production system, the dashboard page is not loading without your patch (no top bar, no widgets). Other pages mostly work fine. Unfortunately, that’s not exactly a clean environment.
So I’ve tried to reproduce this on a more controled test system, but there it works as you described without the patch. Strange,…
However, if I reïnstall the patch, it breaks:
[HTTP/1.1 500 Internal Server Error 498ms] on http://<siturl>/wp-content/plugins/matomo/app/index.php?module=CoreHome&action=index&idSite=1&period=day&date=today
Unfortunately I didn’t find the time today to test further.Is there a safe way to reïsntall the plugin on the prod environment without wiping the config & data? It probably makes sense to try to get a reproducable result.
Thanks,
Tim
Hi @timherinckx When you uninstall the plugin, by default it won’t wipe the data but it will wipe the config file which should be automatically recreated on install. The safest way be though to manually remove the plugin from the directory directly and then either uploading it again through the WP upload feature or manually uploading the extracted zip file. Does this help?
Hi @tsteur,
Thanks, work perfectly!
Unfortunately the prod environment keeps behaving quick differently from a clean install.
We’re currently running a promo campaign for the main site till mid Februari, which limits my possibilities to do some test things directly on production.
I’m moving a backup from prod to a test system and test further there, but that might take some time.I’ll keep you posted.
Kind regards,
Tim
Sure no problem if it takes some time. As nobody else had any issues with it so far I’m planning for now to hold off with merging this PR just to ensure it doesn’t make things worse. We might include it in the next release though already. Be great to let us know once you have an update.
Hi @tsteur,
So, finaly some progress 🙂
There were issue with the reverse proxy in front of the website (PURGE ALL was not clearing the full cache). After clearing directly on the reverse proxy, I’m now getting the same as you: still working, but with those errors in the console.
I’ve also managed to set up a copy on test. There I applied your fix.
There seems to be a small error in the version check (line 40).
My version reports as ‘5.6’, which makes that it is detected as 5.5 or older.
If I change ‘5.6.0-rc1’ by ‘5.6’, the fix seems to work:)Kind regards,
Tim
Thanks for all this @timherinckx . Very appreciated. I just downloaded the WP 5.6 release (I’m already on a newer version) and indeed it is marked as version 5.6. Glad I waited for your results 🙂 I’ve done some more testing with different version comparisons and justed the original pull request and a fix will be included in the next release. Thanks again for all your help.
The topic ‘Missing jquery ui widget.min.js’ is closed to new replies.