Missing closing div in product loop

Resolved

(@newshop)

Hello,
I just analysed the source code of my shop archive and noticed some red marked tags. I then compared the structure to Storefront theme and noticed that Neve adds some extra classes (nv-card-content-wrapper, nv-product-image, img-wrap) but the closing div for “nv-product-image” class is missing.
Here is the default structure with Storefront theme:

<li class="product ...">
	<a href="..." class="woocommerce-LoopProduct-link woocommerce-loop-product__link">
		<img src="..." class="attachment-woocommerce_thumbnail size-woocommerce_thumbnail" ... />
		<h2 class="woocommerce-loop-product__title">Title</h2>
	</a>
	<a href="..." class="button product_type_simple">Read more</a>
</li>

And this is how it should be with Neve:

<li class="product ...">
	<div class="nv-card-content-wrapper">
		<a href="..." class="woocommerce-LoopProduct-link woocommerce-loop-product__link">
			<div class="nv-product-image ">
				<div class="img-wrap">
					<img src="..." class="attachment-woocommerce_thumbnail size-woocommerce_thumbnail" ... />
				</div>
				<h2 class="woocommerce-loop-product__title">Title</h2>
			</div> ---> THIS </div> IS MISSING!
		</a>
	</div>
</li>

This topic was modified 4 years, 10 months ago by newshop.
This topic was modified 4 years, 10 months ago by newshop.
This topic was modified 4 years, 10 months ago by newshop.

Viewing 10 replies - 1 through 10 (of 10 total)

luciamarinescu
(@luciamarinescu)

4 years, 10 months ago

Hi @newshop!

I checked on multiple test instances and for me the structure of the code is correct, there is no div tag that is not closed. This could be caused by some previous customizations made in your code. As you suggested, a solution is to manually add the div tag that misses in your code.

Have a nice day!
Thread Starter newshop
(@newshop)

4 years, 10 months ago
Hi @luciamarinescu,
I just made a fresh installation of Neve theme and disabled all plugins except Woocommerce, but the closing div is still missing (you dont see it in developer tools but in source code. Anyway, the page looks good, but I would like to get rid of these red marked parts in source code). Switching to Storefront solves the problem, switching back to Neve brings the problem back. Is it possible to send you a private message/mail with my website so you can have a look?
Thank you and have a nice day too
- This reply was modified 4 years, 10 months ago by newshop.
luciamarinescu
(@luciamarinescu)

4 years, 10 months ago

Hi @newshop!

We investigated this more and found the missing tag. We reported the issue to our developers.

Thank you and have a nice day!

Thread Starter newshop
(@newshop)

4 years, 10 months ago

Thats good to know, thank you! Looking forward for the update.
Have a nice day too!
Thread Starter newshop
(@newshop)

4 years, 9 months ago
Hello,
just updated to version 3.0.2, cleared the cache and noticed that the closing div for “nv-product-image” class is still missing although it should be fixed due to the changelog (“div tag isn’t closed for products on the shop page”). 🙁
Could you please fix this and release it as a patch?
That would be really appreciated.
- This reply was modified 4 years, 9 months ago by newshop.
Thread Starter newshop
(@newshop)

4 years, 9 months ago

Hello?

Thread Starter newshop
(@newshop)

4 years, 8 months ago

Still not fixed (version 3.0.4.) 🙁

luciamarinescu
(@luciamarinescu)

4 years, 8 months ago

Hi @newshop!

Thanks for following up on the issue and sorry to hear it still occurs! I reported to our developers that this is still an issue.

Have a good day!

Thread Starter newshop
(@newshop)

4 years, 8 months ago

Version 3.0.5 finally fixed it – thank you!

luciamarinescu
(@luciamarinescu)

4 years, 8 months ago

Hello @newshop!

Great, I’m happy to hear it’s solved now!

Have a nice day!

Viewing 10 replies - 1 through 10 (of 10 total)

The topic ‘Missing closing div in product loop’ is closed to new replies.