Media-Tag duplicate submenus fix

In that line of thoughts, when one disables the Media-Tag plugin all the existing Media tags dissapear (which were added via Media-Tag). Similarly, if enabling Media-Tag after adding tags via File-Gallery they dissapear too. Would be nice these dependencies to be exposed via admin cfg params.

The rationale is that using Media-Tag gives the bulk tag mgmt facility that File-Gallery is currently lacking, but this could change in the future versions.

(WP edit timeout?)

Re: “Attach All Checked to Current Post” fix.
Additionally to the commented snippet above, need to change the following:

file-gallery-attach.js ~ li 44:

/*** [alx359] Media-Tags plugin integration. Change line below ****/
//ids     	: jQuery.map(jQuery('.attach_me:checked'),function(i){return jQuery(i).val();}).join(","),
ids     	: jQuery.map(jQuery('.bulk-media-tag-item:checked'),function(i){return jQuery(i).val();}).join(","),

Great, tell us when available and will test.

Hi Bruno,

Haven’t had the chance to test much, but until now everything seems working fine. The only that bothers me a bit is that in the Media Library thickbox (the Upload/Insert link in page/post edits) now there are 2 columns of checkboxes which looks IMO cluttered and confusing. Let me suggest we try to reuse any checkboxes already there (say media-Tags) before creating new ones.

I have added the following piece to file-gallery-attach.js ~23

// adds a checkbox to each attachment not already attached to current post
jQuery('.media-item').each(function()
{
	//// [alx359] a checkbox for this attachment already exists? lets enhance it!
	var cbh = jQuery(this).find(":checkbox"); //short-hand
	if (cbh.length) {
		cbh.addClass('attach_me');
		if( jQuery(this).hasClass("child-of-" + post_id) ) {
			cbh.addClass('empty');
			cbh.prop("checked", true);
			cbh.prop("disabled", true);
		}
	}
	////
	else { // no checkbox found, create a new one!
		if( ! jQuery(this).hasClass("child-of-" + post_id) )
			jQuery(this).prepend('<input type="checkbox" class="attach_me" value="' + jQuery(this).attr('id').split('-').pop() + '" />');
		else
			jQuery(this).prepend('<input type="checkbox" class="attach_me empty" checked="checked" disabled="disabled" />');
	}
	////
});

Additionally, when Media-Tags is installed, it has given us the check-all feature for free 🙂

Cheers,
Alex

Okay, another (and hopefully last) side-effect of the reusing of existing checkboxes idea. When adding class ‘attach_me’, one may also need to ensure the checkbox is properly init. I stumped into this after finding jQuery(‘.attach_me:checked’) returns an array of ‘on’ values even for unchecked elements (the checked ones contain value=id as it should) .

So the (final) patched code:

// adds a checkbox to each attachment not already attached to current post
	jQuery('.media-item').each(function()
	{
		//// [alx359] a checkbox for this attachment already exists? lets enhance it!
		var cbh = jQuery(this).find(":checkbox"); //short-hand
		if (cbh.length) {
			cbh.addClass('attach_me');
			cbh.prop("checked", false);  // proper init state
			cbh.prop("disabled", false); //
			if( jQuery(this).hasClass("child-of-" + post_id) ) {
				cbh.addClass('empty');
				cbh.prop("checked", true);
				cbh.prop("disabled", true);
			}
		}
		////
		else { // no checkbox found, create a new one!
			if( ! jQuery(this).hasClass("child-of-" + post_id) )
				jQuery(this).prepend('<input type="checkbox" class="attach_me css" value="' + jQuery(this).attr('id').split('-').pop() + '" />');
			else
				jQuery(this).prepend('<input type="checkbox" class="attach_me css empty" checked="checked" disabled="disabled" />');
		}
		////
	});