Lost Password – For User’s password reset link doesn’t work

  • Resolved jshare

    (@jshare)


    9 years ago

    I’m using BNFW 1.6.4 together with Paid Membership Pro 1.9.1 (latest), on Ubuntu 16.04.2 LTS with PHP7.0 (latest). I’m on Multisite.

    When a user clicks the Lost Password link on the Login page, they’re receiving the BNFW notification I created using the [password_reset_link] shortcode, which resolves to a link like this:

    https://mydomain.com/login/?action=rp&key=BEM8vcW7uPXaUYzYMu7n&login=1474&utm_source=email&utm_medium=email

    When a user clicks the link, they’re redirected to the Invalid Key page (https://mydomain.com/lostpassword/?error=invalidkey).

    The first problem is that the above url has ‘login=USERID’ when it should be ‘login=USERNAME’.

    If I manually make the change and paste the updated url in my browser instead of clicking the link in the reset password email,
    it works and I’m redirected to the password update page:

    https://mydomain.com/login/?action=rp&utm_source=email&utm_medium=email

    If I inspect the Reset Password form, I can see that it has correct values for the username and the key, corresponding to the ones in my manually updated password reset url.

    The second problem is that if I click Reset Password, I’m now redirected to the Invalid Key page (https://mydomain.com/lostpassword/?error=invalidkey).

    Any suggestions?

    thanks

    Jacob

Viewing 11 replies - 1 through 11 (of 11 total)
  • Plugin Author Jack – BNFW

    (@voltronik)

    9 years ago

    Hi @jshare,
    Thanks for your message.

    There’s two possible issues here.
    Firstly, Multisite isn’t yet supported fully so it’s possible that this is causing an issue.
    Secondly, Paid Membership Pro might be re-writing the URLs for lost password / login / logout links so it’s possible this is causing a problem.

    If you wish to narrow down the issue, I’d recommend starting with PMP and then looking at Multisite.

    Currently, trying to provide support for all the various membership plugins is quite difficult if they don’t provide documentation on their functions or allow other plugins to hook into their plugins at various points.

    Would be interested to know which is causing the issue for you however so please feel free to post back when you find out more.

    Thanks,
    Jack

    Thread Starter jshare

    (@jshare)

    9 years ago

    Jack,
    The PMPro plugin author suggested I disable all plugins except PMPro and see what happens.

    That and further testing confirmed that if I simply disable BNFW 1.6.4, the Password Reset email arrives with a link that works, in this format:

    https://mydomain.com/resetpass/?key=5MPXijd3FK8jon7NXcEm&login=testuser&utm_source=email&utm_medium=email

    One thing worth mentioning is that [password_url], in New User Registration – For User, *does* resolve to a link in the above format and currently works.

    Are [password_url] and [password_reset_link] supposed to be different?

    • This reply was modified 9 years ago by jshare.
    Plugin Author Jack – BNFW

    (@voltronik)

    9 years ago

    Hi @jshare,
    Thanks. That’s interesting.

    If you ensure that none of the GA tracking is added to the URL and then try again with BNFW? I wonder if this is the issue.

    Thanks,
    Jack

    Thread Starter jshare

    (@jshare)

    9 years ago

    If I disable the GA tracking and try again with BNFW, [password_reset_link] resolves to a link like this:

    https://mydomain.com/login/?action=rp&key=O3nujpqGdphLL8sN6eMw&login=4893

    Plugin Author Jack – BNFW

    (@voltronik)

    9 years ago

    Hi @jshare,
    Thanks – does this link now work without the GA tracking or not?

    Thanks,
    Jack

    Thread Starter jshare

    (@jshare)

    9 years ago

    Sorry, I should have said that!

    No, it does not.

    Thread Starter jshare

    (@jshare)

    9 years ago

    Btw, with WP_DEBUG enabled on my test server, when I click the Lost Password link, this is what I see in my error log:

    2017/05/14 21:49:49 [error] 13194#0: *41425 FastCGI sent in stderr: “PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/bnfw.php on line 402
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 609
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 611
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 612
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 613
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 614
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 615
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 616
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 617
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 618
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 619
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 620
    PHP
    2017/05/14 21:49:49 [error] 13194#0: *41425 FastCGI sent in stderr: “ns/bnfw/includes/engine/class-bnfw-engine.php on line 619
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 620
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 621
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 626
    PHP message: PHP Notice: Trying to get property of non-object in /var/www/mydomain.com/html/wp-content/plugins/bnfw/includes/engine/class-bnfw-engine.php on line 298” while reading response header from upstream, client: xx.xxx.xxx.xxx, server: mydomain.com, request: “POST /lostpassword/ HTTP/2.0”, upstream: “fastcgi://127.0.0.1:9000”, host: “mydomain.com”, referrer: “https://mydomain.com/lostpassword/”

    I can generate this with PHP7.0 or PHP7.1.

    Plugin Author Jack – BNFW

    (@voltronik)

    9 years ago

    Hi @jshare,
    Thanks for this.

    Let me do some investigating and I’ll get back to you.

    Thanks,
    Jack

    Plugin Author Jack – BNFW

    (@voltronik)

    9 years ago

    Hi @jshare,
    I can confirm that this issue is caused by Multisite.
    Multisite support is coming in the Summer via an add-on but there’s no release date as yet.
    There’s not much more I can do for now except perhaps to look into redirects in order to get the URL that you need.

    Thanks,
    Jack

    Thread Starter jshare

    (@jshare)

    9 years ago

    Thanks for figuring it out.

    In the meantime, I’m not including [password_reset_link] in the Password Reset email, instead telling the user to reply to it so I can handle it manually, and I have no clue how often it’ll come up…

    But I’ll admit I was thinking of hacking the plugin to see if I could make the New User email’s [password_url] work in the Password Reset email. Wouldn’t that work?

    Plugin Author Jack – BNFW

    (@voltronik)

    8 years, 12 months ago

    Hi @jshare,
    It might do but you’ll loose any changes on new updates to BNFW.

    Hope the Multisite add-on will be good for you when it’s released!

    Thanks,
    Jack

Viewing 11 replies - 1 through 11 (of 11 total)

The topic ‘Lost Password – For User’s password reset link doesn’t work’ is closed to new replies.