Localization: missing load_plugin_textdomain() and hardcoded strings in admin.js

  • Resolved Afshari

    (@saeidafshari)


    1 week, 5 days ago

    Hi, thanks for the plugin. I’m the Persian (fa_IR) translation editor for it on WordPress.org, and while testing the translation I noticed two things:

    1. load_plugin_textdomain() is never called anywhere in the plugin. Since WP 6.7, relying on just-in-time loading can fail and leave strings untranslated. Adding it on the init hook would fix it.
    2. Some of the text in assets/js/admin.js is hardcoded in English, so it never reaches the POT file and stays untranslated. Passing those through llmscuAdmin.strings or wp.i18n would solve it.

    Happy to test a patched build. Thanks.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Sean Mullins

    (@seanmullins)

    1 week ago

    Hi Afshari,

    Thank you so much for this (both for taking the time to identify the localisation issues and for completing the Persian translation.) I really appreciate it.

    Your report came at exactly the right time as I was finishing the 2.0 release. I went back through the localisation implementation carefully as a result, including the JavaScript strings you highlighted, and made sure the new Curator interface was covered too.

    2.0 has now been submitted to WordPress.org. (literally about 30 mins ago). Your contribution genuinely improved the release, rather than just resulting in something being added to a future list, so thank you for speaking up when you spotted it.

    Do let me know if any issues I can look into, particularly with Persian/RTL, where you’ll inevitably spot things that I won’t.

    Thanks again for contributing your time to the plugin.

    Sean 🙂

    Plugin Author Sean Mullins

    (@seanmullins)

    4 days, 12 hours ago

    Resolved with 2.0 release.

Viewing 2 replies - 1 through 2 (of 2 total)

You must be logged in to reply to this topic.