Javascript error if options set to false
-
Hi there,
Thanks for making this plugin, it helped to quickly setup and test our xmpp server on our webpages.
Just a small bug I found while testing
In conversejs.php you’ve the following lines:$call = (get_option('call')) ?: false; $carbons = (get_option('carbons')) ?: false; $foward = (get_option('foward')) ?: false;which should be:
$call = (get_option('call')) ?: 'false'; $carbons = (get_option('carbons')) ?: 'false'; $foward = (get_option('foward')) ?: 'false';as false casted to string yields an empty string, thus the javascript generated below contains errors.
Cheers,
Guillermo
Viewing 2 replies - 1 through 2 (of 2 total)
Viewing 2 replies - 1 through 2 (of 2 total)
The topic ‘Javascript error if options set to false’ is closed to new replies.