Issue with Minify CSS Files option and CSS Custom Properties

  • Resolved Creative Themes

    (@creativethemeshq)


    5 years, 3 months ago

    Hello team,
    We recently discovered that if the Minify CSS Files option is enabled it starts to remove the unit from a CSS Variable fallback.

    It should be like this margin: var(--margin, 0px) but when this option is enabled it makes it like this margin: var(--margin, 0) – without unit.
    To be honest this is a bad practice to remove the unit.

    In some cases where we make calculations with calc() – this breaks everything because the calc function doesn’t know what units to take in consideration.

    Could you please take a closer look on this and let us know if you could fix this issue?

    Thank you.

Viewing 16 replies (of 16 total)
1 2
  • Thread Starter Creative Themes

    (@creativethemeshq)

    5 years ago

    @hristo-sg Thanks for letting us know, we didn’t know you adhere to this convention. We’ll make sure to update our CSS files to have the min.css extension while enqueueing it in the minified form. Does that hold for JavaScript files too?

Viewing 16 replies (of 16 total)
1 2

The topic ‘Issue with Minify CSS Files option and CSS Custom Properties’ is closed to new replies.