Infinite Loop on Installation if $tmp_base is not writeable

  • Resolved Not Just Code

    (@notjustcode)


    5 years, 6 months ago

    Hi,

    WP 5.5.3, plugin version 2.7.1, Nginx server.

    Line 501 of includes/class-wcpdf-main.php in init_tmp() checks if $tmp_base is a directory and if it isn’t, logs an error, but carries on processing.

    This means that copy_fonts() is called on line 508, which calls get_tmp_path(), which checks for $tmp_base and if it’s not a directory, calls init_tmp(), which logs an error and calls copy_fonts(), which calls get_tmp_path() which calls init_tmp(), etc…

    It would be useful if the installer could exit gracefully after the initial $tmp_base check on line 501 and let the user know that there’s a problem with their directory permissions, rather than locking the server in an infinite loop.

    Thanks,

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Contributor Ewout

    (@pomegranate)

    5 years, 6 months ago

    Hi! Thanks for reporting and apologies for the inconvenience. This is a regression – we’ve had a proper check in place for this but with the recent update to randomize the temp folder it seems we lost this check. We’ll try to get an update out to fix this.

    For our information: was this on a clean/new install of the plugin or on an existing installation after moving the temporary folder location?

    Thread Starter Not Just Code

    (@notjustcode)

    5 years, 6 months ago

    No problem – I thought it would be a regression as previously the plugin has notified us about directories it needed access to.

    We run our WP installs on tightly locked down nginx setups, so appreciate it when plugins a) acknowledge that nginx exists and b) lets us know what directories to make accessible.

    In answer to your question: clean, new install of the plugin.

    Plugin Contributor alexmigf

    (@alexmigf)

    5 years, 6 months ago

    Hi @notjustcode

    Could you please test with this branch and let us know if it fixes the issue?

    Thread Starter Not Just Code

    (@notjustcode)

    5 years, 5 months ago

    Clean install of WP5.5.3 and branch release from the link above resulted in a clean install and activation.

    Issue fixed.

    Thanks!

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Infinite Loop on Installation if $tmp_base is not writeable’ is closed to new replies.