Incorrect href on image link

  • Resolved Jason Paul

    (@jasontrasaterracom)


    11 years, 7 months ago

    1. I’ll specify the Image Link URL:
    ex: http://www.somesite.com/subsitename/2014/09/01/the-florida-keys-an-intriguing-arts-destination/

    2. When I look at the rendered HTML I get two different hrefs, the second oneis a dud link..it adds CPT to the link string:

    <div id="5729" class="item next left">
<a href="http://www.somesite.com/subsitename/2014/09/29/first-look-the-art-collection-at-park-hyatt-new-york/"></a>
<a title="Title Name" href="http://www.somesite.com/subsitename/cptbc/first-look-the-art-collection-at-park-hyatt-new-york/">
<img class="attachment-full wp-post-image" width="1740" height="1030" alt="serra_2resized" src="http://somesite.com/imagename.jpeg" scale="0">
</a>
<div class="carousel-caption">...
</div>

    Is the only workaround to add an html link in the excerpt for now?

    Separate issue, but I tried to use the background image option to compensate for this problem. Fixes the linking but the background image does not size appropriately like images.

    https://wordpress.org/plugins/cpt-bootstrap-carousel/

Viewing 8 replies - 1 through 8 (of 8 total)
  • Thread Starter Jason Paul

    (@jasontrasaterracom)

    11 years, 7 months ago

    Hm, it’s become clear that I’ve got a function that is creating that issue. It’s a function to auto wrap featured thumbnails with links. I’ll have to figure out a way around this. Thanks. I think you can close this issue.

    Plugin Author Phil Ewels

    (@tallphil)

    11 years, 7 months ago

    Hi Jason,

    Glad you tracked the problem down, good luck with fixing it. Regarding the background images issue, that feature is new and relatively untested at the moment, so if it’s doing weird stuff let me know and I’ll look into it.

    Cheers,

    Phil

    Thread Starter Jason Paul

    (@jasontrasaterracom)

    11 years, 7 months ago

    Thanks! The background image appears as a different size than the image version. It would be cool if they behaved to look exactly the same.

    Plugin Author Phil Ewels

    (@tallphil)

    11 years, 7 months ago

    Oh ok.. This is kind of the point of the background image mode – to stretch / crop each image to fit the space available in the carousel (with the manual height adjustment). Just use the default mode if you want to see the entire image.. Or am I not understanding you correctly?

    Phil

    Thread Starter Jason Paul

    (@jasontrasaterracom)

    11 years, 7 months ago

    I had it at default. But the background images were not positioned right and I did specify the height (does there need to be an auto height, or blank for that to work correctly?)

    Plugin Author Phil Ewels

    (@tallphil)

    11 years, 7 months ago

    Ah ok – if you’re not using the background images mode then the height value doesn’t do anything (apologies, this isn’t very clear – the settings page has been rewritten in the new dev version to help with this). On the default mode the images show as they are – if they’re narrower than the carousel they won’t stretch to fit the width, and the carousel height will change according to the varying heights. In other words, you need to adjust your images to fit the carousel before uploading.

    The background-resize mode aims to get around this by using a different technique. The height is set manually and fixed, then the images are stretched / cropped accordingly.

    Does this make sense?

    Phil

    Thread Starter Jason Paul

    (@jasontrasaterracom)

    11 years, 7 months ago

    I think so. I’ll hold off until you release the new version. Sounds like you’ve addressed this in the new version coming up!

    Plugin Author Phil Ewels

    (@tallphil)

    11 years, 7 months ago

    Ok, cool. You can grab the dev code from github if you’d like: https://github.com/ewels/cpt-bootstrap-carousel

    I still have a couple of extra things that I want to work out before I push the next release and I’m pretty busy at the moment, so not sure exactly when I’ll find the time to sit down and get that out.

    Phil

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘Incorrect href on image link’ is closed to new replies.