hyphenation in

  • Resolved TimThemann

    (@timthemann)


    9 years, 12 months ago

    Hi,

    unless <h1> and <h2> are excluded from processing, <title> seems to get processed also (even if excluded). As IE11 seems to display any soft hyphen as a hard hyphen in the page title, that behavior leads to unwanted results for IE users (page titles are displayed with a lot of hyphens in them). As far as I can see (or guess 😉 ), the issue is caused by the first if-statement in function process() (class-php-typography.php). Unfortunately, I do not really understand the implications of changing that statement. As I´d like to process <h1> and <h2> (at least the quotation marks), I´d really appreciate a fix for this issue.

    Thanks for the great plugin

    Tim

    https://wordpress.org/plugins/wp-typography/

Viewing 15 replies - 1 through 15 (of 32 total)
1 2 3
  • Plugin Author pepe

    (@pputzer)

    9 years, 12 months ago

    What version of WordPress and what theme are you using? Normally this should not happen.

    Thread Starter TimThemann

    (@timthemann)

    9 years, 12 months ago

    WordPres 4.4.2, theme “Catch Box”. Did you look at the code I mentioned? As far as I can see, it specifically refers to the exclusion of <h1> and <h2> – which is the behavior I observed.

    Plugin Author pepe

    (@pputzer)

    9 years, 12 months ago

    The issue is not caused by that code, but rather by the theme using a filtered value for the <title> tag. Please have a look at the way the theme fills the <title> tag and post that code snippet here. (I’m assuming it does not use add_theme_support( 'title-tag' );.)

    Plugin Author pepe

    (@pputzer)

    9 years, 12 months ago

    Ah, I just saw that this is a free theme. I’ll have a look at it myself.

    Plugin Author pepe

    (@pputzer)

    9 years, 12 months ago

    Have you got a link where I can see the problem on your site? I cannot reproduce the behaviour you describe with the free version of Catch Box.

    Thread Starter TimThemann

    (@timthemann)

    9 years, 12 months ago

    Unfortunately, I can not reproduce it anymore, too. On Saturday, the problem was pretty much stable (do not exclude <h1>and <h2>, get a lot of &shy;­s in <title> – exclude <h1> and <h2>, no ­&shy;s in <title>). Turned on and off the issue a couple of times for testing, the issue was perfectly reproducable. The only plugin updated since yesterday is the “Add Meta Tags” plugin – which interferes with the <title>, too. I´ll have a look at the code changes of that plugin …

    Thread Starter TimThemann

    (@timthemann)

    9 years, 12 months ago

    OK, it´s still reproducable. Had to use Chrome or IE to see the ­&shy;s in <title>. See https://die-computermaler.de/impressum/ .

    Plugin Author pepe

    (@pputzer)

    9 years, 12 months ago

    Please try disabling the Add Meta Tags to see if the problem is triggered by wp-Typography alone.

    Plugin Author pepe

    (@pputzer)

    9 years, 12 months ago

    I’ve since installed both Catch Box and Add Meta Tag locally. Neither apply wp-Typography’s filters to the <title> tag. Please disable all your plugins except wp-Typography and re-enable them one by one to see which one is the cause.

    (As a workaround, if you are just concerned because of soft hyphen rendering, you can disable hyphenation in headings via the wp-Typography settings.)

    Thread Starter TimThemann

    (@timthemann)

    9 years, 12 months ago

    Interestingly, the “disable hyphenation in headings” setting does not have any effect in my installation: Even if I disable hyphenation in headings from the settings, h1, h2 and title are still hyphenated.

    Testing plugin compatibility will take some time … I´ll keep you updated.

    Many thanks for your support!

    Plugin Author pepe

    (@pputzer)

    9 years, 12 months ago

    Then something strange is going on. I suspect some plugin applies filters hooked to the_content to the whole page.

    Thread Starter TimThemann

    (@timthemann)

    9 years, 12 months ago

    Temporarily deactivated (one-by-one) any plugin hooking the_content in my production environment (ouch!) – no change, still &shy;s in <title>.
    Installed a test WP environment, copied over my live plugins directory and activated wp-Typography as the only plugin with defaults. Still &shy; in <title>. Excluded <h1> and h2: no &shy;s in <title>. The issue is pretty much stable and reproducible even in my very limited test environment. I´m confused ;-).

    Thread Starter TimThemann

    (@timthemann)

    9 years, 12 months ago

    Actually, it even happens with Twenty Fourteen.

    Plugin Author pepe

    (@pputzer)

    9 years, 12 months ago

    Can you post some minimal example content that triggers the behavior in a code block here? I’m trying to reproduce this in a fresh installation locally.

    You are using WP 4.4.2 with wp-Typography 3.2.3? Site language? Just the default settings for wp-Typography?

    Plugin Author pepe

    (@pputzer)

    9 years, 12 months ago

    OK, I have finally been able to reproduce this, though I’m not sure how the filter get’s applied to the title.

Viewing 15 replies - 1 through 15 (of 32 total)
1 2 3

The topic ‘hyphenation in’ is closed to new replies.