Support » Plugin: Slideshow » HTML Errors

  • Resolved kYem

    (@kyem)


    There are couple of things, that are easy to fix and make them html valid: frontend_attachement.php Line 55.

    <div class="slideshow_slide slideshow_slide_image">
    				<a <?php echo $anchorTagAttributes; ?>>
    					<img src="<?php echo htmlspecialchars($imageSrc); ?>" alt="<?php echo $alt; ?>" width="<?php echo $imageWidth ?>" height="<?php echo $imageHeight; ?>">
    				</a>
    				<div class="slideshow_description slideshow_transparent">
    					<a>>
    						<?php echo !empty($title) ? '<h2>' . $title . '</h2>' : ''; ?>
    						<?php echo !empty($description) ? '<p>' . $description . '</p>' : ''; ?>
    					</a>
    				</div>
    			</div>

    Should be changed to

    <div class="slideshow_slide slideshow_slide_image">
    				<a <?php echo $anchorTagAttributes; ?>>
    					<img src="<?php echo htmlspecialchars($imageSrc); ?>" alt="<?php echo $alt; ?>" width="<?php echo $imageWidth ?>" height="<?php echo $imageHeight; ?>"/>
    				</a>
    				<div class="slideshow_description slideshow_transparent">
    						<?php echo !empty($title) ? '<h2><a'. $anchorTagAttributes .'>' . $title . '</a></h2>' : ''; ?>
    						<?php echo !empty($description) ? '<p><a'. $anchorTagAttributes .'>' . $description . '</a></p>' : ''; ?>
    				</div>
    			</div>

    That would fix the self closing error on the img tag and the block/inline element errors.

    The last one is in slideshow.php, line 8

    <div class="slideshow_pagination"><div class="slideshow_pagination_center">
    <ul></ul>
    </div></div>

    This will cause the end tag for “ul” which is not finished html error as you actually need li element with it.

    One solution is to create the ul tag inside jQuery and the populate it with list items. It would fix the html problem.

    Now the last one, document type does not allow element “style” here, I assume will be sorted out eventually.

    http://wordpress.org/extend/plugins/slideshow-jquery-image-gallery/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Stefan Boonstra

    (@stefanboonstra)

    Thanks for sharing this information! It would indeed be better to move the anchor tags inside the elements and to have jQuery create the unordered list.

    I’ll apply these fixes in version 2.2.8.

    Plugin Author Stefan Boonstra

    (@stefanboonstra)

    The style element will be moved to the bottom of the page in version 2.2.8 as well. This will make the stylesheets cahcheable, so this has multiple advantages.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘HTML Errors’ is closed to new replies.