Ok, so I found another one
when you do the apply filters for thwdpf_add_rule_discount the $product variation on line 585 isn’t the right product, logically it should be the minimum price variation, but it’s the maxium price one even though the other price variables are consistent with the minimum price variation.
We are checking with our technical team. We will get back to you once we get an update from them.
Sounds good, I found another bug in the meantime (You guys should start paying me)
When you get the product discount there is an “is_admin()” conditional check which returns price, you need to check whether it’s also an ajax call, because is_admin() will return true on ajax calls.
It essentially means your plugin doesn’t work with ANY filter plugin that uses ajax
Let me answer your questions one by one.
>>If you put a product into the cart and look at that products product page or see it in a list, it will show the strikeout html from when it’s in the cart.
>>when you do the apply filters for thwdpf_add_rule_discount the $product variation on line 585 isn’t the right product
We believe you’ve suggested these as potential improvements. If that’s the case, we’d love to look into these issues in more detail. Could you please submit a ticket through our website? Our technical team will check it further.
>>When you get the product discount there is an “is_admin()” conditional check which returns price, you need to check whether it’s also an ajax call, because is_admin() will return true on ajax calls.
We have forwarded your suggestion to our technical team. They will check the feasibility of adding this in future versions.
Thank you!
Lol, these are not suggestions these are bugs. I had to fix it through an integration, you can have it for a price, but you won’t get it for free.
We understand that you’ve identified a few issues, and we truly appreciate your thorough analysis.
Let me answer your questions one by one.
>>If you put a product into the cart and look at that products product page or see it in a list, it will show the strikeout html from when it’s in the cart.
>>when you do the apply filters for thwdpf_add_rule_discount the $product variation on line 585 isn’t the right product
We believe that this could be a bug, and we’ll need to investigate it further. As mentioned in previous update, please submit a ticket so our team can review and resolve this.
>>When you get the product discount there is an “is_admin()” conditional check which returns price, you need to check whether it’s also an ajax call, because is_admin() will return true on ajax calls.
We will look into this issue and evaluate the feasibility of implementing a fix in future versions of the plugin. We appreciate your patience as we continue to enhance the plugin’s functionality.
Thank you again for your valuable input. Our team is committed to improving the plugin, and we will prioritize these fixes as we plan upcoming updates.
Thank you!
Why would anyone buy your plugin if you aren’t going to fix the bugs *now*? Currently with the admin ajax, any sort of woocommerce site worth their salt will select another plugin than yours as ajax helps incrase sales.
You do remember how I said that any ajax calls will stop your plugin from applying discount rules right? The minicart does not work because of this. I even told you what was wrong, a fix for these bugs should not take more than a day.
Or you could send me money and I’ll fix your plugin.
Thank you for bringing these issues to our attention. We truly appreciate your detailed feedback and understand how important these fixes are for a seamless experience.
We want to assure you that your concerns have been noted, and we are actively working to address them. These fixes are a priority, and we aim to include them in an upcoming release as part of our commitment to improving the plugin.
Thank you for your patience and understanding as we strive to make our plugin better for everyone.
