Feedback about plugin

  • Resolved lamington

    (@lamington)


    7 years, 3 months ago

    Hi Vladimir. I think you’ve created a wonderfully powerful plugin, but I want to give some feedback about issues with the implementation that are a bit rough.

    Tooltips: there have been problems with this shortcode for a long time, not least relating to the positioning of the tooltip windows, and nothing seems to have been fixed. (1) The width responsiveness of the tooltip is terrible – the window easily ends up too narrow, off-screen, or just mislocated (there are other threads about this, but no real fix). (2) You appear to have unnecessarily hardcoded a lot of layout into the CSS which is difficult to diagnose or override – for instance line-height of text in a tooltip.

    Buttons: Again, there is a lot of hard-coded styling which is difficult to control. Why does the method of specifying the padding of buttons change in the CSS at different screen widths, for instance? (And the CSS has an !important added, making it even harder to fix.) Also, as a suggestion for the buttons, it should be possible to specify no URL at all (either to display an example button, or so that you can embed, for instance, a lightbox link).

    It seems that often the hardcoded CSS from the plugin is inappropriately overriding the site’s theme CSS, which goes against good design principles. Perhaps it’s just the legacy of the development work you’ve done over time on this plugin. I look forward to seeing how this great plugin develops further.

Viewing 1 replies (of 1 total)
  • Plugin Author Vova

    (@gn_themes)

    7 years, 3 months ago

    Hi @lamington,

    I totally agree about tooltips. It’s a piece of the really old code. I will remake it later.

    Why does the method of specifying the padding of buttons change in the CSS at different screen widths, for instance?

    I’m not sure I understand what do you mean. Could you provide more details?

    And the CSS has an !important added, making it even harder to fix.

    I use !important across the plugin to make sure themes are not overriding necessary styles. Trust me, themes are often poorly-coded. This approach helps me to reduce the number of conflicts.

    Also, as a suggestion for the buttons, it should be possible to specify no URL at all (either to display an example button, or so that you can embed, for instance, a lightbox link)

    That isn’t obvious, I suppose, but you can use javascript:; as URL value to give a button an empty link. Probably, I should add this to the documentation. Example:

    [su_button url="javascript:;"] A button without link [/su_button]

    It seems that often the hardcoded CSS from the plugin is inappropriately overriding the site’s theme CSS, which goes against good design principles.

    I wish I could remove it, but I can’t. There are tons of themes which force me to follow this approach.

    Perhaps it’s just the legacy of the development work you’ve done over time on this plugin. I look forward to seeing how this great plugin develops further.

    Somewhere it is, somewhere it isn’t.

    Thank you for the feedback. I will keep making this plugin awesome for everyone 🙂

Viewing 1 replies (of 1 total)

The topic ‘Feedback about plugin’ is closed to new replies.

Tags