Excluding classes from WP-Typography not working?

  • Resolved Triseult

    (@triseult)


    7 years, 10 months ago

    Hi!

    I don’t know if this is a bug with WP-Typography or I’m doing something wrong… In the interest of improving the plugin, I’m reporting it here!

    So WP-Typography garbles one of my plugins on one of my pages… I confirmed this by disabling and enabling WP-Typography, it’s definitely the issue here. You can see the messed-up plugin at the end of the post here:

    http://www.helenesepromene.com/how-to

    Easy to fix, surely… I just have to exclude the class “home-post-share” which includes the whole sharing box. So I did that in my WP-Typography settings… But nothing seems to work.

    I even tried to include other classes, but nothing works.

    Can you please advise?

    Thank you!

    The page I need help with: [log in to see the link]

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author pepe

    (@pputzer)

    7 years, 10 months ago

    The other plugin is making incorrect assumptions about the_title() and should use the_title_attribute() instead (question 3 in the FAQ).

    Excluding the class of the enclosing element does not work in such cases because the filter (and thus wp-Typography) is only handed the title itself, not the calling context.

    Thread Starter Triseult

    (@triseult)

    7 years, 10 months ago

    Ah, I understand. It’s picking up the typographied info from the_title() instead of the_title_attribute(), which explains why it’s not getting excluded from WP-Typography?

    Got it!

    Thank you for your very quick feedback!

    Plugin Author pepe

    (@pputzer)

    7 years, 10 months ago

    the_title_attribute() is actually a wrapper around the_title() that also calls strip_tags().

    I might offer a “whole page” mode in the future. That would do away with all the different filter hooks and just process everything with output buffering. Things might break, though, if the underlying HTML parser does not like a certain syntax (has happened with some of the newer JS attribute annotations).

    Thread Starter Triseult

    (@triseult)

    7 years, 10 months ago

    I see. You’ve definitely helped me solve this particular issue… I see where to fix it in the plugin I’m using. Thanks again. 🙂

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Excluding classes from WP-Typography not working?’ is closed to new replies.