Oh… it`s not possible to copy the code before and after complete. Therefore I try to describe the “after” situation.
After saving the code into the sucess message field the first part from script begining until scritp ending disapears.
Plugin Author
Franky
(@liedekef)
That’s because that setting is currently not allowed to have javascript in it.
This should fix it:
https://plugins.trac.wordpress.org/changeset/1602068/
Hi Franky,
I see, but I regret the fix doesn`t work properbly at all.
Any idea why?
I replaced both files with the new once you given.
BR,
DieSpeedy
Plugin Author
Franky
(@liedekef)
You’re correct, in fact you just stumbled on a bug …
This should fix it:
https://plugins.trac.wordpress.org/changeset/1602352
(if not working now, then wait a bit, trac is slow sometimes …)
Mhm… it still doesn`t work. 🙁
Because trac is slow, I´ll use additionally a chrome plugin to verify the correctness of the code implementation. But it doesn`t regognize it.
Plugin Author
Franky
(@liedekef)
Well, the diff that’s being represented by trac doesn’t seem correct to me …
so download the whole file and see the diff for yourself:
https://plugins.trac.wordpress.org/browser/events-made-easy/trunk/eme_options.php
Mhm, I tried it several times with the downloaded files under different circumstances (including testpage visisble for all). But something still went wrong.
Google Addon tells me:
Missing HTTP Response
Missing HTTP Response denotes that, while the AdWords Conversion Tracking code was detected in the page source, the script itself did not execute. Each time the Conversion Tracking script executes, we expect an HTTP Response carrying the Conversion Tracking request to Google’s servers carrying conversion_id, conversion_label, conversion_value and page URL.
This means that the Conversion Tracking code is not implemented properly on the page and no conversions will be tracked.
Recommended Action: Reinstall the Conversion Tracking snippet by removing the current iteration, copy a new version from the AdWords interface, and insert that version into the site.
I can send you some files/screenshots to a dropbox if you want.
It still seems, that after I save the event the “vars” became deleted from the success message area. I guess, thats the reason, why it still doesnt work. Or what do you think?
Plugin Author
Franky
(@liedekef)
Ok, first let’s agree on the setting you’re trying to change. Can you tell me the English setting?
Also, after reflection, you shouldn’t be using javascript there (too easy for XSS then), so I advise you to set your javascript in the EME header/footer settings.
Mhm, I`m not sure if I got, what you are asking for.
The setting I try to change you finde below “page=eme-options&tab=rsvp”. The point I would translate to “Message after sucessful booking”.
There I insert: Thank you for booking
+ the Google Code for tracking
Regarding EME header/footer settings I´m lost. Because the script must be only(!) on the successful page not on every eventpage.
Does this answer your question?
Plugin Author
Franky
(@liedekef)
Yep it does 🙂
2 things:
– that setting still doesn’t have the option to add javascript to it (I need to check to make sure I didn’t accidentally allow all settings to have javascript now)
– concerning the code: using jquery you can check if a specific field-id exists and only then execute the code, that would solve it too, no?
Mhm, I regret I am not fimilar enough using jquery.
Tried to add the following into the footer of the event page:
if ( $( “#eme-rsvp-message” ).length ) {
$( “#eme-rsvp-message” ).show(); // This part would later be replaced by Google Script
}
But it didn`t work… only the code is displayed.
Are you willing to support me with this, too?
Plugin Author
Franky
(@liedekef)
jquery is in the end javascript, so you need to enclose your jquery with
<script type="text/javascript"> and </script> tags
Also: in the header/footer no event placeholders are replaced, so you need to use id-‘s in your thank-you message. The easiest would be to create hidden span-id’s or something in your thank-you message, if wanted all enclosed in another hidden div (also with an id of your choice) and check for the presence of that div-id.
Mhm, Im sure I understood what to do, but it doesnt work… 🙁
I tried the following. Add to the success message the new element “divConfirmation”.
<div id=’eme-rsvp-message’><div class=’eme-rsvp-message eme-rsvp-message-success’><div id=”divConfirmation”>Dies ist ein Testtext</div>Ihre Buchung wurde erfolgreich übermittelt.</div></div>
Add to the footer the script as followed:
<script type=”text/javascript”>
$( “#divConfirmation” ).show();
</script>
But it seems like it will not be executed.
I would expect ot have the text above visible in the Footer, too. Even with alert(“Hello World”); it doesn`t work…
Am I still doing something wrong?
Okay, I tried something different. The code seems correct implemented now (without any if div exists) just to check, if it`s working in general.
Now I guess, Im having a different issue regarding no http response (as already described above). Thats why I am trying to fix that issue first with the help of Google Ads Forums.
So, I guesst, that`s no longer an issue of EME. 😉
Thank you for your support right now.