Drag and Drop Category Order Broken

If I make the following mods to the code for the UPCP_Get_Catalog_Overview() function in “Functions/Shortcodes.php”, I get the expected behavior.

– global $wpdb, $fields_table_name, $link_base;

+ global $wpdb, $fields_table_name, $link_base, ;

…

– if ($Overview_Type == “Categories”) {$Items = $wpdb->get_results(“SELECT * FROM $categories_table_name WHERE Category_ID IN (” . $ID_String . “) ORDER BY Category_Sidebar_Order”);}

+ if ($Overview_Type == “Categories”) {$Items = $wpdb->get_results(“SELECT * FROM $categories_table_name LEFT JOIN $catalogue_items_table_name ON $catalogue_items_table_name.Category_ID = $categories_table_name.Category_ID WHERE $categories_table_name.Category_ID IN (” . $ID_String . “) ORDER BY $catalogue_items_table_name.Position”);}

I did not use that as there is no indicator on mouse-over to make it apparent that this is a drag and drop list. Such an indicator does display on the list in Catalogue tab. Three people looked at this without discovering that the Category list is drag and drop as well.

It still seems to me that the order on the Catalogue tab list should control the order of the categories on the Category Overview page. What does the Position column control if it doesn’t control this?

The desired functionality is available, but, I think the user interface is confusing, and to some degree contradictory.

I would still like to make a case for using the modification I proposed. It makes sense to me, that if I change the order of categories on the Catalogue tab, that it would control the Catalogue Overview page. It is confusing to reorder the entire list of categories if not all of them are to be used in a particular catalogue. Further, the video documentation (https://www.etoilewebdesign.com/plugins/ultimate-product-catalog/documentation-ultimate-product-catalog/) indicates that the Catalogue tab list controls the Catalogue Overview order.

If it’s not going to be used, then remove the code to offer the drag and drop functionality. Also, could the Category tab list have an indicator on mouse over, or some other indicator to make it clear that this is where the order is maintained?

• This reply was modified 8 years, 4 months ago by tdmoose.

In my first post, I indicated this option setting.

* In the UPCP dashboard, set Options->Basic->Category Overview Mode to “Categories Only”

When you do this, the category order is not followed. It behaves as I have described. Since you have confirmed in your past post that “the drag and drop in the Catalogues tab affects what you see in the main area (the right side, opposite the sidebar) on the catalogue page,” I would consider what I have brought up to be a bug. Please fix it.

I really doubt that you carefully tested this using the condition I detailed in my first post.

The reason I doubt it, is, that when I step through the code, I can see the query it uses to display the result. That query cannot produce a correct result. I can verify that the code is actually going through this query via error_log statements. The query is the one I posted earlier. This query uses “Category_Sidebar_Order”, but, it should use “Position” in the “…Catalogue_Items” table.

I’ll mark this as resolved, but, I stand by my claim that the software does not function as expected.

• This reply was modified 8 years, 4 months ago by tdmoose.