• Resolved KTS915

    (@kts915)


    This looks a really promising plugin, and it’s obviously under very active development.

    Unfortunately, your use of inline CSS (especially with the !important attribute) makes it exceptionally difficult to re-style so as to blend well with any theme.

    Could you please take out the inline CSS and move it into an external stylesheet, preferably taking out the !important attributes at the same time?

    I’m also not a fan of including a custom CSS page as part of the plugin’s settings; it’s an unnecessary additional stylesheet, which just adds to loading time.

    I much prefer to add my CSS to my theme’s style.css file, because styling is always theme-specific. The irony is that, while you include inline CSS with the !important attribute, it makes it impossible for me to make the changes I want, even if I were prepared to use the plugin’s custom CSS page.

    https://wordpress.org/plugins/ultimate-member/

Viewing 15 replies - 1 through 15 (of 18 total)
  • Plugin Author Ultimate Member

    (@ultimatemember)

    Hi!

    Thanks very much, please be sure that we’ll take this feedback “seriously”.

    We’ll indeed remove the custom css option from plugin as it does not seem necessary.

    The inline css (is dynamic css) we can’t load it externally as we want to allow users to style each form with its unique ID differently. That’s why we did it to include the style below the form.

    However, we’ll remove the !important rules. Let us know if that answer satisfy your needs, or need more explaination. We’re ready to answer your queries.

    Thank you

    Thread Starter KTS915

    (@kts915)

    Thank you. That all sounds very fair!

    Plugin Author Ultimate Member

    (@ultimatemember)

    You’re welcome. My pleasure to read your feedback/comments always.

    Thread Starter KTS915

    (@kts915)

    Unfortunately, you don’t seem to have implemented this change yet. I’d be grateful if you would.

    Plugin Author Ultimate Member

    (@ultimatemember)

    We have added option to turn off custom css tab by default which was one of the requests you’ve made here 🙂

    We just have to make sure that removing !important rules won’t cause theme conflicts as a lot of themes use them already.

    Thread Starter KTS915

    (@kts915)

    Well, I didn’t actually ask for that. I just pointed out that it was unnecessary. But thanks anyway.

    I understand why you might be concerned about removing the !important attributes. But, if you don’t, your plugin’s use will effectively be restricted to sites with a matching color scheme. On my sites, that blue and gray is completely out of place, and so renders the plugin unusable.

    Plugin Author Ultimate Member

    (@ultimatemember)

    Can you send me a link to your site where you’re using the plugin? You do not have to, but I thought you’d want me to look at the issue and just try to see how that color could be overridden. If you can’t put a link to that page, I will understand. You are welcome to join the forum and make it as a private reply too. And please accept my apologies

    Thread Starter KTS915

    (@kts915)

    Thanks for the offer, and there’s no need to apologize. You have done nothing to apologize for. I just would like a way to customize the appearance of the plugin that you’ve kindly made avaialble.

    If my install were on a site you could access, I’d be happy to show you. But I develop every new site on localhost first and only put it up on an accessible server when I think it’s ready. So it’s not possible to share a link at the moment.

    Obviously, I could just go into the plugin and modify the bits I want to change. But those changes would get overridden by an update. The only way this problem can be avoided is if you remove the !important attributes. As I say, I think this will be better for plugin adoption in the long run anyway.

    Could I suggest that you take a look at how Peter Featherstone has done this for his Responsive Menu plugin? The default installation of that plugin comes with !important attributes in the inline CSS. But there is also an option in the plugin’s admin to have those attributes removed so that the CSS can be overridden by users who wish to do that.

    Plugin Author Ultimate Member

    (@ultimatemember)

    I will have a look at that plugin and see how he does it. Can you please tell me the css rules/the areas of the plugin that you are trying to change? We would like to remove a couple of the !important rules from the CSS you are dealing with directly and see if other users complain of theme compatibility before we remove more of them.

    Thanks!

    Thread Starter KTS915

    (@kts915)

    Sure!

    I am talking first about things on the Account page, specifically:
    .um-um_account_id.um input.um-button[type="submit"], .um-um_account_id.um input.um-button[type="submit"]:focus, .um-um_account_id.um a.um-button {background: none repeat scroll 0% 0% #3BA1DA !important;}

    In addition, I have now found that, despite the fact they have no !important attribute, I have been unable to change the color for the following:

    .um-account-side li a.current span.um-account-icon, .um-account-side li a.current:hover span.um-account-icon {
        color: #3BA1DA;
    }
    .um-account-side li {
        background: none repeat scroll 0% 0% #EEE;
    }

    But the User page has a similar problem, specifically:

    .um-profile-nav-item.active a {
        background: none repeat scroll 0% 0% #3BA1DA !important;
        color: #FFF !important;
    }

    Thank you.

    Thread Starter KTS915

    (@kts915)

    I have now resolved the issue with .um-account-side li — something else was interfering.

    But the other problems remain.

    Plugin Author Ultimate Member

    (@ultimatemember)

    We’ve now made changes (preparing for next update) and removed many of the !important rules, especially those linked to plugin main color, from all css files. We’ll release the update tomorrow, if you continue to have problem with any rules after that, please let us know them here so we can filter them out.

    Thread Starter KTS915

    (@kts915)

    Thank you very much indeed! I look forward to trying it out!

    Plugin Author Ultimate Member

    (@ultimatemember)

    We’ve just pushed the update. Let me know if any other rules need tweaking and we’ll work on it.

    Thread Starter KTS915

    (@kts915)

    This is perfect. Thank you very much!!

Viewing 15 replies - 1 through 15 (of 18 total)

The topic ‘CSS issue’ is closed to new replies.