Copy Stylesheet Assets to Combine Folder

  • Resolved pha3z

    (@pha3z)


    13 years, 6 months ago

    Negative side-effect of combine:

    URL() references in the stylesheet break if they are relative to the stylesheet. Example: Revolution Slider plugin comes with its own PNG shadows and a dynamically generated stylesheet that displays a shadow user-chosen shadow below the slider. Combine did a perfect job of including the stylesheet in the Combined file, but the URL reference to the shadow PNG is invalidated so the browser look in the wrong place for the shadow.

    Proposed Solution A:
    Parse URL() references and copy the assets to folder where combined CSS file is saved.

    Proposed Solution B:
    Intelligently, modify URL() references in combined sheet to correctly reference the location of the assets relative to the combined sheet location.

    Thoughts?

    http://wordpress.org/extend/plugins/combine-css/

Viewing 5 replies - 1 through 5 (of 5 total)
  • Thread Starter pha3z

    (@pha3z)

    13 years, 6 months ago

    In retrospect, Solution A is prone to problems. If a given stylesheet is referencing assets at a higher level directory or a sibling directory, then you can’t just copy the assets into the combine directory with the new stylesheet. Since this situation is highly likely to occur for some plugins or themes, Solution B would be far more elegant.

    How difficult do you think it’d be to accomplish this?

    Plugin Author timmcdaniels

    (@timmcdaniels)

    13 years, 6 months ago

    Solution B should be possible. I will take a look this evening and over the weekend. I will be back in touch soon!

    Plugin Author timmcdaniels

    (@timmcdaniels)

    13 years, 5 months ago

    Hello pha3z,

    I just released version 0.4, and it addresses your issues. There are a number of other changes to the plugin as well (please review change log). Please let me know if this helps with your issues.

    Thanks,

    Tim

    Thread Starter pha3z

    (@pha3z)

    13 years, 5 months ago

    Woot! It appears to work seamlessly! I updated the plugin and now the images show up! The architecture changes sounds like smart moves as well! Terrific work!

    Thanks,
    Jim

    Plugin Author timmcdaniels

    (@timmcdaniels)

    13 years, 5 months ago

    resolved.

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Copy Stylesheet Assets to Combine Folder’ is closed to new replies.