Category headings not displaying correctly

katchups
(@katchups)

10 years, 10 months ago

So here’s my page I’m building out for a client:
http://katrinachu.com/wpLeibsohn/listings/retail/
In the category section in the right-hand menu, I’ve made three categories. If I select one of the categories, it populates the page with posts from that category and displays the category name in the page header. However if I select another category, the post list changes but the header at the top doesn’t and still shows the name of the category from my previous selection.

I’ve created a child theme, so maybe this has something to do with it, but I haven’t done anything custom to the php files and even switching back to the original Modality theme doesn’t change anything. Anyone have an idea of what’s going on?

Viewing 3 replies - 1 through 3 (of 3 total)

Michael
(@alchymyth)

10 years, 10 months ago
caused by this section in title-section.php of the theme:
```
if (is_category() || is_single()) {
    	$category = get_the_category();
			if($category[0]){
				echo '<h1 class="section-title-right">'; echo esc_attr($category[0]->cat_name); echo '</h1>';
			}
	}
```
instead of using the single_cat_title() https://developer.wordpress.org/reference/functions/single_cat_title/ for the category archive page, it is using https://developer.wordpress.org/reference/functions/get_the_category/ outside the loop to output the first of some post categories which can be rather erratic if (some of) the posts have more than one category …
mrs_helga
(@mrs_helga)

10 years, 9 months ago

I have the same problem. So what should i write in my code? Any snippet? I’m not good at php…
Giorgio25b
(@giorgio25b)

10 years, 5 months ago
I guys,
this is what I did in my child-theme
```
if (is_category() || is_single()) {
    	// $category = get_the_category(); // original code
    	// $category = single_cat_title(); //in case you want to use if($category[0])
			// if($category[0]){
			if(is_category()){
				// echo '<h1 class="section-title-right">'; echo esc_attr($category[0]->cat_name); echo '</h1>';
				echo '<h1 class="section-title-right">'; echo esc_attr(single_cat_title()); echo '</h1>';
			}
	}
```
I left the original lines, commented out, just for semplicity;
for some reason they decided to create a variable $category and to create a conditional statement based on that, so I basically created an other if condition where only if is_category() use single_cat_title.

Thanks Michael for pointing me in the the right direction 😉
Hope it helps