Bug with color picker validation

  • Resolved raphaeldupertuis

    (@raphaeldupertuis)


    8 years, 5 months ago

    Hello,

    I’ve just installed your plugin which looks really nice!
    I have a bug with form validation with date pickers : if I submit my form without selecting a color (fields are set as required), I get HTML code displayed instead of the proper message. I can’t add a link as it’s on my client’s dev server but here is a screenshot : https://preview.ibb.co/gbNXEb/Capture_d_e_cran_2017_12_07_a_14_02_17.png

    I’m running WP 3.9.1 with Woocommerce 3.2.5 and WC Fields Factory 2.0.3 (I’ve just tried to re-download the files with no luck).

    IS this a known issue?

    Cheers!
    Raphael

    The page I need help with: [log in to see the link]

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Saravana Kumar K

    (@mycholan)

    8 years, 5 months ago

    Hi, sorry for that, some how I missed that during testing,

    I added a feature that whenever validation failed for any failed, I will try to retain other fields value as filled by the user, so that they won’t have to fill again, thats what caused the issue.

    Will release the fix soon.

    Until then please use Show Hex Value as as Show the Color Code

    Plugin Author Saravana Kumar K

    (@mycholan)

    8 years, 5 months ago

    Hi, the fix is released available with Version 2.0.4, please update

    Thread Starter raphaeldupertuis

    (@raphaeldupertuis)

    8 years, 5 months ago

    Wow thank you, that was fast! Now the HTML is not displayed anymore but neither is the validation message if the field is blank. You can now check it our live here : https://craftdeko.ch/produit/coussin-de-naissance-personnalisable/

    Also, there is a bug with datetime picker : date picker seems to work fine but there is a JS error thrown in the console when enabling time picker as well.
    Please let me know if you need me to start a new topic or to provide more info.

    Thank you for your amazing work!

    Raphael

    Plugin Author Saravana Kumar K

    (@mycholan)

    8 years, 5 months ago

    Hi, no need,

    That time picker issue is, I missed to enqueue the timepicker addon script. I will release the fix for both issues shortly.

    Plugin Author Saravana Kumar K

    (@mycholan)

    8 years, 5 months ago

    Hey one more feedback, I am adding that extra suffix (required) on each fields placeholder, if the field is mandatory,

    after seeing your product page, which is not English but that (required) suffix looks awkward,

    Should I keep it or make it optional.?

    Plugin Author Saravana Kumar K

    (@mycholan)

    8 years, 5 months ago

    The reason that no error message is displayed (If you have noticed that, the product also not getting added to Cart) is that you haven’t given any error message,

    please specify the error message (for each field the config name is Message) that has to be displayed on validation failed.

    Thread Starter raphaeldupertuis

    (@raphaeldupertuis)

    8 years, 5 months ago

    Thank you for your follow up!

    It would be amazing to make the “(required)” label optional or editable indeed! I was about to try to edit it but I’d rather not edit plugin files. Good idea!

    Thank you for your reply for the error message, I thought there was a default message setup, now I understand.

    Thank you for your great customer service, a lot of paying plugins’ editors should learn from you! Have a great weekend!

    Thread Starter raphaeldupertuis

    (@raphaeldupertuis)

    8 years, 5 months ago

    Hey Saravana,

    It works fine with a Message text, thank you!

    Small suggestion: adding an AJAX validation instead of reolading the form as if there is a validation error, it will empty fields which are not managed by WC Fields Factory (for example, I use Visual Attributs to manage the first field with the small cliparts). It’s not a big issue though.

    Another question, is it possible to manually give names to hex color codes so that the client sees real colors in the cart instead of the hex values?

    Thank you again for your amazing work!

    Raphaël

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘Bug with color picker validation’ is closed to new replies.