Bug Found!
-
In class.akismet.php file line 1122 it has:
if ( apply_filters( 'akismet_debug_log', defined( 'WP_DEBUG_LOG' ) && WP_DEBUG_LOG ) ) {According to WordPress documents WP_DEBUG_LOG should only be usable when WP_DEBUG is set to true. The line above only checks that WP_DEBUG_LOG is true but there are countless sites who will have WP_DEBUG = false but WP_DEBUG_LOG = true…this is so it makes it easy for one to enable debugging right away via WP_DEBUG=true without having to also change the boolean for the other values too.
so the CORRECT WAY to implement this line is:
if ( apply_filters( 'akismet_debug_log', defined( 'WP_DEBUG' ) && WP_DEBUG && defined( 'WP_DEBUG_LOG' ) && WP_DEBUG_LOG ) ) {Right now, even when WP_DEBUG is off Akismet writes endless logs to error_log because WP_DEBUG_LOG = true, but WP_DEBUG=false. Yikes!
Please fix
Viewing 1 replies (of 1 total)
Viewing 1 replies (of 1 total)
The topic ‘Bug Found!’ is closed to new replies.